Repository navigation
WIRE-439: align node-owner scenarios with new-account-only registration - #188
Draft
joshglogau wants to merge 1 commit into
Draft
joshglogau wants to merge 1 commit into
joshglogau wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Align the canonical scenarios with the admin-approved WIRE-439 policy: node-owner NFT registration creates new accounts only.
nodeownregfor valid NFT claims and slashing voters; remove their separate account-creation steps.ACCOUNT_EXISTS(7) for matching and different public keys. Preserve the production BAR → OPP registration path and other rejection cases.newnameduserhelpers for setup, remove the unused slashing creation wrapper, and document the required ROA/MSGCH contract pair. No SDK, payload or dependency changes.Verification
Affected NFT/slashing project typechecks, targeted ESLint, and the ROA action suite (3 tests) pass with pinned pnpm 10.32.1. Full lint and TypeScript build also pass. GitHub Build and test / Jest CI is green. Local macOS still fails unchanged
StartScriptRenderer(1) andBindConfigNetwork(4) cases, including with host permissions; those unrelated paths are untouched. Full multi-chain NFT/slashing runs are not claimed; they need the companion contracts.Companion
Wire-Network/wire-sysio#767 — required ROA/MSGCH contract pair.
Wire-Network/wire-hub-webapp#242 — new-account-only onboarding, stacked on Wire-Network/wire-hub-webapp#241.