Repository navigation
WIRE-439: restrict node-owner claims to new accounts - #767
Draft
joshglogau wants to merge 8 commits into
Draft
joshglogau wants to merge 8 commits into
joshglogau wants to merge 8 commits into
Conversation
Change-Id: I622f4c346ca4eed323f5aaca77d6751dc5717cc7
Change-Id: I93cd68c81137191c881226c09b9f085e94b357db
Change-Id: I8d51b10b76475c365faf119cd1fc4ba345be0f20
Change-Id: I14fae99267a55370fe846682ffa26ab4f2d9b0dc
Change-Id: I3ce5eb434008a5ada8fead632516b6a92edd0e03
Change-Id: I4efd23669f99a9e1c51f6c5606fd8373f6e20e52
Change-Id: Id3107ab0b98010394e17fc4c10c2142be9c37963
Change-Id: Icf262a04b0c508e3761f8cadfd9d77efbff3db5d
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Implements the admin-approved WIRE-439 policy: node-owner registration creates new accounts only. Copying an existing account's public active key cannot authorize an Ethereum link.
ACCOUNT_EXISTS(7); preserves duplicate, invalid-name, link-conflict and tier-cap outcomes.nodeownreg. ROA atomically creates the account, allocates its tier throughforcereg, and records the depositor's AuthEx link.No BAR, protobuf or SDK change. Previously bound links and escrowed NFTs are not remediated by this patch.
Rollout
Deploy ROA and MSGCH together, or quiesce inbound dispatch until both are installed; mixed revisions are incompatible. Hub name checks cannot reserve a name, so a later collision can still reject and leave the NFT escrowed.
Companions: Wire-Network/wire-tools-ts#188 and Wire-Network/wire-hub-webapp#242 (stacked on Wire-Network/wire-hub-webapp#241).
Verification
contracts_projectbuild passed with CDT4d36a654; both ABIs are unchanged.c0a27c981bchanges comments only; its CI rerun remains pending.