Skip to content

WIRE-353: align emissions E2E and bootstrap docs with no-expiry DClaim - #107

Merged
huangminghuang merged 6 commits into
masterfrom
fix/wire-339-wire-353-dclaim-no-expiry
Oct 9, 2026
Merged

huangminghuang merged 6 commits into
masterfrom
fix/wire-339-wire-353-dclaim-no-expiry

Conversation

@huangminghuang

@huangminghuang huangminghuang commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Validate DClaim bootstrap configuration without requiring the removed expiry window, and document indefinite claimability with retained import controls.
  • Remove obsolete expiry fields from returned-collateral claim fixtures while preserving balance, token-selection and timeout assertions.
  • Reject malformed packed collateral codes before planning configuration actions, preserving exact chain/token identity and the zero sentinel.
  • Require published SDK/shared packages 1.0.96 and wallet SDK 0.1.84 so standalone installs receive the no-expiry contract declarations.

Why

The approved WIRE-353 policy extends WIRE-339 no-expiry behavior to DClaim. The old positive-window assertion and expiry-bearing fixtures no longer match the producer. The emissions flow still requires the configuration row, open bootstrap import window, and its accounting/payout invariants.

Collateral conversion must not silently drop high bits or select a different asset. The guard checks safe nonnegative integer input and an exact packed-code round trip before producing ABI strings.

Validation

  • Published SDK 1.0.96 ESM/CJS declarations verified through a standalone npm install: retired expiry fields/actions are absent and the yield-debt table is present.
  • A separate registry-only checkout builds successfully and passes 73 focused collateral readback/configuration, syndication bootstrap and Andon tests, including balance mismatch timeouts, missing/truncated reads, high-bit loss and malformed packed codes.
  • Live E2E was not rerun for this candidate. The task owner explicitly approved a scoped E2E exception for this consumer update after registry validation and independent review.

Companion PRs

Change-Id: I82bc7af73e8e60ee27304c0e68ebcbbb66ef9c84
Change-Id: Ie1d3421757320cc8bc34700c5adf3ba69f41a897
Change-Id: Id0d4e389b4dfcbd2def944b6fa78e31f4308edd1
@huangminghuang
huangminghuang marked this pull request as ready for review September 28, 2026 13:53

@jglanz jglanz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving code only, product reqs/features are unavailable.

@huangminghuang
huangminghuang marked this pull request as ready for review October 9, 2026 15:07
@huangminghuang
huangminghuang merged commit 6c4bd01 into master Oct 9, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants