Repository navigation
WIRE-353: align emissions E2E and bootstrap docs with no-expiry DClaim - #107
Merged
Merged
Conversation
Change-Id: I82bc7af73e8e60ee27304c0e68ebcbbb66ef9c84
huangminghuang
marked this pull request as ready for review
September 24, 2026 23:47
huangminghuang
marked this pull request as draft
September 25, 2026 16:26
Change-Id: Ie1d3421757320cc8bc34700c5adf3ba69f41a897
Change-Id: Id0d4e389b4dfcbd2def944b6fa78e31f4308edd1
huangminghuang
marked this pull request as ready for review
September 28, 2026 13:53
jglanz
approved these changes
Oct 8, 2026
jglanz
left a comment
Contributor
There was a problem hiding this comment.
Approving code only, product reqs/features are unavailable.
huangminghuang
marked this pull request as draft
October 8, 2026 18:05
huangminghuang
marked this pull request as ready for review
October 9, 2026 15:07
heifner
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The approved WIRE-353 policy extends WIRE-339 no-expiry behavior to DClaim. The old positive-window assertion and expiry-bearing fixtures no longer match the producer. The emissions flow still requires the configuration row, open bootstrap import window, and its accounting/payout invariants.
Collateral conversion must not silently drop high bits or select a different asset. The guard checks safe nonnegative integer input and an exact packed-code round trip before producing ABI strings.
Validation
Companion PRs