Repository navigation
WIRE-339/WIRE-353: keep all four claim ledgers claimable indefinitely - #639
Conversation
Change-Id: I9229d58dd4e48493d2e68fdd19919e07fec3b8af
…ve-unused-claim-expiry Change-Id: I8da3a94ceab8b263078acd69bd996bbcde8e2cea
Change-Id: I0cd043b6256feb8929f893936f9553f781fda072
|
Could you add What would need to go:
The deploy order flips compared with when the sweep was added. |
Change-Id: I6ebfaa8f417e512494ae02d74f9f03c1f9607158
Change-Id: I221d108b3debaa86d66088ea2542de2714e48045
Change-Id: Ia3391aaba071c612e791b4b386780bcf2e03b748
Change-Id: I9095a408fb17f356d5779a536794261eb1ab687c
Change-Id: Ic779128aa04e5b646ad293bae68c762e57ab3e86
heifner
left a comment
There was a problem hiding this comment.
No code issues. The contracts compile from source, and every committed wasm/abi reproduces byte-for-byte.
docs/contract-upgrade-order.md: rule 3 contradicts the call-edge bullet and the "inverts" paragraph below it (L216-225). For a removed action the caller deploys first, which is this release's order. Maybe phrase it as: every action the deployed caller inlines must exist in the deployed callee (added → callee first, removed → caller first). Downgrades step 2 still says "all three claim tables", but dclaim's rows changed too.- Leftovers:
RESERV_ACCOUNT(sysio.epoch.hpp:129) and../sysio.reserv/include(sysio.epoch/CMakeLists.txt:40) are unused now.<sysio/system.hpp>insysio.dclaim.hpp:8only servednow_sec().- The "nobody ever pulls" comment at
emissions_tests.cpp:5096no longer fits the test.
Change-Id: I1a326bfd964f4dba5c90d0665d8878204bc4fad0
Change-Id: I4913da0e42c5a3d148dc738b246063fb0d85b2fe
Change-Id: I676f909612da757d8ebdefe95a044df3a1111588
Change-Id: I72f6bbebeee123afa5a3a14b7c3d394952f1d5f3
Change-Id: Ied58d7d7db71232b59c3eb08c4c62ac63bd82f58
Change-Id: I6fc94229e235433149f394c3d1ee07f87e7aa0d5
Change-Id: I62d1cec60eb56ca2af23a0151a14cc9d319cd825
CertiK WNS-63 (WIRE-413) is fixed on master by Wire-Network#594 (links sweep unmapped credits), Wire-Network#639 (credits never expire) and Wire-Network#670 (onreward retired). The SVM createlink sweep had no unit test; the new one also checks that a credit sharing the key's 8-byte bychainad prefix stays put. A link sweeps once and createlink does not check that the DClaim import is sealed, so the upgrade-order doc now says to finish the import before the first link. Change-Id: I50e69a120633181dd3d9e0dd100c3e5a663af844
Summary
yielddebtswithout blocking registration;claimyieldworks after the operator record is gone.sysio.reserv/sysio.uwritand the existing unpaid-claim protection insysio.bond. Rebuild the affected artifacts and document fresh-state schema and rollback requirements.Why
WIRE-339 establishes the no-expiry policy; the approved WIRE-353 scope includes DClaim rewards and imported credits. Administrative operator removal must not erase earned yield or returned collateral. The upstream collateral redesign introduced a new forfeiture path during pruning and re-registration; the separate debt ledger preserves that entitlement without retaining an obsolete operator registration.
This is a pre-launch schema change for fresh state. Claim and debt rows intentionally retain system-funded storage until collected. Uncovered yield remains an obligation and becomes a payable WIRE remit only when its yield pool has backing. Slashing, settlement rulings, transport retention, and cleanup of fully paid bond requests keep their existing semantics.
Validation
a16738c488, focused JIT operator-registry, DClaim, AuthEx, and emissions suites plus three bond-retention regressions passed 221 cases / 7,878 assertions. Coverage includes years of inactivity, delayed linking, repeated registrations, archived debt plus new yield, token identity, zero backing, bounded large-debt collection, and downstream LIQ-failure rollback.claimremitand the newyielddebtstable; the companion SDK still needs regeneration against this contract set.20591bfd, SDKfdbddd26, and Tools78f39784. Those historical results do not validate the new syndication/debt interface; no current coordinated E2E result is claimed.Companion PRs