Repository navigation
Add exact depot swap quotes with pending yield and output fees - #98
Merged
Merged
Conversation
joshglogau
changed the base branch from
feature/syndication-underwriting
to
master
October 8, 2026 18:37
joshglogau
marked this pull request as ready for review
October 8, 2026 18:37
Removed details about artifact library consumption and depot trade estimation from the SDK core section.
bearcubsvet
approved these changes
Oct 14, 2026
Removed outdated sections on account decoder, swap quotes, API documentation, and tests. Consolidated installation and documentation information.
bearcubsvet
approved these changes
Oct 14, 2026
valthon
approved these changes
Oct 14, 2026
valthon
left a comment
Contributor
There was a problem hiding this comment.
No blocking correctness findings. The 22 quote tests passed locally against this head, and hosted CI passed. Arithmetic matches the inspected depot source; live swap parity and the full local CI gate were not rerun. One nonblocking documentation finding is attached inline.
bearcubsvet
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
contracts.sysio.swap.quoteSwap, a pure exact-input depot estimate over generated pool and LIQ rows. It accrues pending holder yield before pricing and returns exact gross output, output-denominated fees, net output and minimum output.Validation: workspace build, lint and 969 tests / 84 suites pass, including 22 quote cases. README TypeScript examples also pass strict type checking. Published producer dependencies were used without sibling artifact links. Lockfile validation and platform flow tests remain waived; live swap parity is not claimed.
Consumer: Wire-Network/wire-hub-webapp#191 uses indicative quotes with execution disabled. #108 separately updates outpost artifacts. Publish this helper through the normal SDK release after review; execution consumers must refresh coherent state, validate authority/Andon and enforce positive minimum output on chain.