Repository navigation
fix(sdk-core): align launch ABIs with Andon, desyndication minimum, and reward retirement - #97
Closed
joshglogau wants to merge 2 commits into
Closed
joshglogau wants to merge 2 commits into
joshglogau wants to merge 2 commits into
Conversation
Contributor
Author
|
Closing as superseded by merged upstream work: #100 supplies the native-permission Andon declarations, #102 supplies the Sysio #670 return-minimum and retired reward-carrier alignment, and #87 supplies the non-expiring claim interfaces and retained operator yield debts. These are now on master; maintaining this older generated-ABI branch would duplicate that work. Hub operator and node-owner integration will consume current master and its normal SDK release. #98 remains the separate, still-needed depot swap quote helper. This closure does not claim publication or live sandbox acceptance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align the declarations inherited from #92 with the launch contract set, including merged Wire-Network/wire-sysio#662 and the review follow-up Wire-Network/wire-sysio#670. Regenerated all 20 checked-in system ABIs at
517de37142660624904001082ac34cfed9afeccfusing SYSIO's existing generator and this repository's formatter; verified exact output parity.pull({ reason }),clear({ note }), andcord; remove actor arguments,addpuller,setpanic,andonconfig, and syndicationfrozen_mark.min_desyndicatein syndication configuration. Remove DClaimonreward/reward cursors, LIQ kicker actions/configuration,fundclaim, the retired T5 shortfall field, and staking-reward attestation enum member.No new clients, runtime codecs, dependencies, package bumps, or producer changes. The existing generated facade covers these actions.
Validation (October 8): workspace build, lint, 943 tests / 82 suites, and generated-output parity pass; the commit hook repeated lint/build/tests. Local strict-null validation and the new CI run stop at
Builtins.ts:89(TS2722), owned by #91; CI compilation passed before that step. No duplicate fix here. Local dependencies use registry producer artifacts, so this is not a clean frozen-lockfile publication certification. Broken platform flow tests are waived; no live deployment or transaction acceptance is claimed.Dependencies / companions: draft stacked on
feature/syndication-underwriting(#92). Wait for Wire-Network/wire-sysio#670 to land; its incompatible contract/table changes need a fresh-state deployment. Wire-Network/wire-tools-ts#112 must adopt native Andon setup, the required minimum, and retired reward/kicker removal before a coherent sandbox respin. Publish matching producer models and SDK packages through the normal release workflow. #98 remains the separate exact swap-quote helper; Wire-Network/wire-hub-webapp#191 retains swap UI with indicative read-only quotes and disabled submission. Operator integration continues in Wire-Network/wire-hub-webapp#181; council SDK work stays in #96. No Hub changes, merges, releases, or respins in this pass.