Skip to content

Keep connection list health compact by default - #1648

Open
baggiiiie wants to merge 1 commit into
UsefulSoftwareCo:mainfrom
baggiiiie:lean-connection-health
Open

Keep connection list health compact by default#1648
baggiiiie wants to merge 1 commit into
UsefulSoftwareCo:mainfrom
baggiiiie:lean-connection-health

Conversation

@baggiiiie

Copy link
Copy Markdown
Contributor

issue

see #1647

root cause

the root cause for this issue is, connection.lastHealth is copied directly to connections.list output, and its schema used the full HealthCheckResult. The existing verbose option controlled only the full OAuth scope string, not health diagnostics.

fix

connections.list now outputs:

  • Default or verbose: false: status, identity, and checkedAt only.
  • verbose: true: the complete health result, including httpStatus, detail, and responseSample.

Connection detail, create, refresh, and HTTP API behavior remain unchanged. Unit and end-to-end tests cover both compact and verbose responses.

@baggiiiie

Copy link
Copy Markdown
Contributor Author

hmm the ci failures seem to be flaky tests? this PR only touches core-tools.ts, the failures shouldn't be caused by the diff

i think cloud2 has flaky test assertion, cloud5 could be some load-dependent bug

@RhysSullivan

Copy link
Copy Markdown
Collaborator

good pr thanks

@RhysSullivan

Copy link
Copy Markdown
Collaborator

yeah they're flakey tests, will fix

@baggiiiie
baggiiiie force-pushed the lean-connection-health branch from 199c893 to aa6a3e1 Compare August 20, 2026 06:44
@baggiiiie

Copy link
Copy Markdown
Contributor Author

hmm hey Rhys @RhysSullivan one job in ci got timeout'ed at bun install --frozen-lockfile, issue with blacksmith runner?

https://github.com/UsefulSoftwareCo/executor/actions/runs/32340881974/job/96339586996?pr=1648

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants