Keep connection list health compact by default - #1648
Open
baggiiiie wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
hmm the ci failures seem to be flaky tests? this PR only touches i think cloud2 has flaky test assertion, cloud5 could be some load-dependent bug |
Collaborator
|
good pr thanks |
Collaborator
|
yeah they're flakey tests, will fix |
This was referenced Aug 18, 2026
baggiiiie
force-pushed
the
lean-connection-health
branch
from
August 20, 2026 06:44
199c893 to
aa6a3e1
Compare
Contributor
Author
|
hmm hey Rhys @RhysSullivan one job in ci got timeout'ed at https://github.com/UsefulSoftwareCo/executor/actions/runs/32340881974/job/96339586996?pr=1648 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue
see #1647
root cause
the root cause for this issue is,
connection.lastHealthis copied directly toconnections.listoutput, and its schema used the fullHealthCheckResult. The existingverboseoption controlled only the full OAuth scope string, not health diagnostics.fix
connections.listnow outputs:verbose: false:status,identity, andcheckedAtonly.verbose: true: the complete health result, includinghttpStatus,detail, andresponseSample.Connection detail, create, refresh, and HTTP API behavior remain unchanged. Unit and end-to-end tests cover both compact and verbose responses.