Fix two more CI e2e flakes: picker hydration race and dev-db ghost affinity - #1658
Merged
Conversation
Contributor
Cloudflare previewTorn down — the PR is closed. |
@executor-js/cli
@executor-js/config
@executor-js/execution
@executor-js/sdk
@executor-js/plugin-file-secrets
@executor-js/plugin-graphql
@executor-js/plugin-keychain
@executor-js/plugin-mcp
@executor-js/plugin-onepassword
@executor-js/plugin-openapi
@executor-js/codemode-core
@executor-js/runtime-quickjs
executor
commit: |
RhysSullivan
changed the title
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-cloud | b298d9d | Aug 18 2026, 04:59 PM |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | b298d9d | Commit Preview URL Branch Preview URL |
Aug 18 2026, 04:59 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fourth CI e2e flake surfaced on PR #1648's runs (after #1656 cleared the first three):
google-health-checkstimed out waiting for the "Connect an integration" dialog. The failure screenshot shows the Integrations page with the Connect button rendered and no dialog:waitUntil: "networkidle"does not mean the console has hydrated, so a click that lands between the SSR paint and React attaching the handler is swallowed without a trace, and the dialog never opens.Adds
clickToReveal(trigger, revealed)to the browser surface — re-click until the revealed element is visible, with the final attempt surfacing the ordinary locator timeout — and uses it at the three call sites that open the integrations picker this way (google-health-checks,google-photos-preset-ui,provider-plugins-ui).Verified: lint, e2e typecheck, and all three scenarios pass locally against a cloud stack.
dev-db ghost affinity (second wedge mode)
The
cloud signIn: callback set no session (500)cascade recurred on this PR's own run — #1656 fixed one wedge mode but there is a second: a client whose socket dies while its pipeline-opening entry is executing.detach()clears pipeline affinity before the entry finishes, the queue then assigns affinity to the already-dead handler, and nothing is left to release it — every other connection (including fresh startups) queues behind the ghost forever. The queue now tracks detached handlers and repairs any transaction or pipeline affinity they can no longer release (ROLLBACK / wire-level Sync).New regression test reproduces the exact CI signature on the unfixed code (bystander dies with
CONNECT_TIMEOUT) and passes with the fix; all 5 socket tests pass.