Skip to content

Fix CUDA Cholesky workspace handling - #11

Merged
karl-kes merged 2 commits into
UWHPC:mainfrom
KerelosGayed:kg/fix-cuda-cholesky-workspace
Sep 26, 2026
Merged

karl-kes merged 2 commits into
UWHPC:mainfrom
KerelosGayed:kg/fix-cuda-cholesky-workspace

Conversation

@KerelosGayed

@KerelosGayed KerelosGayed commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

CUDA Cholesky factorization called buffer::size(), which does not exist, preventing the float and double CUDA factorization paths from compiling.

Replace workspace_.size() with workspace_.count() at the call site to pass the requested workspace element count to the existing cusolver_potrf helper. Its signature stays unchanged.

Validation:

  • git diff --check passed.
  • Inspected the existing float/double CUDA Cholesky tests, which exercise this call through factorization and solve.
  • CUDA compilation/runtime tests were not run locally because nvcc is unavailable.

@karl-kes karl-kes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you keep cusolver_potrf's signature as it was and just swap workspace_.size() for workspace_.count() at the call site? The next step would be to use buffer_view<T> where applicable in a follow up PR

@karl-kes karl-kes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karl-kes
karl-kes merged commit 10efcac into UWHPC:main Sep 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants