Repository navigation
Pass Cholesky workspace as buffer_view - #12
Merged
karl-kes merged 1 commit intoSep 30, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #11.
cusolver_potrftook the workspace as a separate pointer and size, which is how thesize()/count()mismatch in #11 slipped in. It now takes anxpu::buffer_view<T>, so the pointer and element count come from the same object, and the call site passesworkspace_.view().To support this,
buffer_viewgets adata()accessor that follows the same constness deduction asoperator[].This is the only internal helper that passes a pointer with a separate length.
cusolver_getrftakes no workspace size, andfill_n/copy_nare left alone since they are public std-style APIs.Validation:
buffer_view::data()on mutable, const, empty, and owner views.git diff --checkpassed.