pass inflow actions as method references instead of strings - #26
Open
adamkorynta wants to merge 1 commit into
Open
pass inflow actions as method references instead of strings#26adamkorynta wants to merge 1 commit into
adamkorynta wants to merge 1 commit into
Conversation
Member
Author
|
@eabkrebs - note the more idiomatic python change using method reference. These were applied to as part of SWL's example scripts |
adamkorynta
force-pushed
the
feature/method_reference_inflow_actions
branch
from
August 19, 2026 21:05
2e3da14 to
a04d27d
Compare
adamkorynta
commented
Aug 19, 2026
| "autoAdjust @ Bull_Shoals_Dam", | ||
| "computeInflow @ Norfork_Dam", | ||
| "cloneInflows @ Norfork_Dam", | ||
| "autoAdjust @ Nofork_Dam", |
Member
Author
There was a problem hiding this comment.
@eabkrebs - note that this typo has been fixed with the refactor here
rma-psmorris
approved these changes
Aug 21, 2026
this allows for less code redundancy and less fragility with string names
adamkorynta
force-pushed
the
feature/method_reference_inflow_actions
branch
from
August 21, 2026 18:27
a04d27d to
06db905
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this allows for less code redundancy and less fragility with string names