Feature/jpype script migration - #23
Conversation
adamkorynta
commented
Jul 16, 2026
- adds in basic smoke test against scripts to ensure API's are reachable from the wheel without moving to integration test territory
194ce49 to
958df67
Compare
The merge-base changed after approval.
958df67 to
a30a554
Compare
rma-psmorris
left a comment
There was a problem hiding this comment.
compute_All_Flowgroups and compute_Single_Flowgroup are duplicated across several of the GateFlow scripts. Does it make sense to move these into a shared module rather than defining them as nested functions in each script? If this makes sense and is outside of the scope of this effort, capture it as a ticket? -- Although, capturing as a ticket would have the cat out of the box by the time we revise possibly making it too late to take advantage of.
Note that milestone 4 validates the scripts converted to the JPype workflow.
The redundant code is purely the logic for error handling, which is the responsibility of individual scripts and not the library. We could write a library method that iterates over an array and then return a list of exceptions, but I don't see a large benefit or reduction in code duplication there (but allows callers to completely ignore errors....). One other consideration that I don't like all that much is adding into regi_python_logging is a helper like: |
rma-psmorris
left a comment
There was a problem hiding this comment.
Also reviewed and approved stacked PRs