Repository navigation
ci: defer cargo, integration, and coverage lanes to nightly - #2877
Merged
MarcusSorealheis merged 3 commits intoOct 19, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This comment has been minimized.
This comment has been minimized.
b7r6
force-pushed
the
ci/nightly-redundant-lanes
branch
from
October 3, 2026 20:32
5356c33 to
d1a9e1e
Compare
b7r6
force-pushed
the
ci/nightly-redundant-lanes
branch
from
October 3, 2026 20:37
d1a9e1e to
49a657f
Compare
b7r6
changed the title
b7r6
force-pushed
the
ci/nightly-redundant-lanes
branch
from
October 3, 2026 20:48
49a657f to
2265ca7
Compare
b7r6
changed the title
b7r6
force-pushed
the
ci/nightly-redundant-lanes
branch
from
October 3, 2026 20:57
2265ca7 to
da552fe
Compare
MarcusSorealheis
previously requested changes
Oct 3, 2026
MarcusSorealheis
left a comment
MarcusSorealheis
left a comment
Member
There was a problem hiding this comment.
We cannot move all of rbe testing to nightly.
b7r6
changed the title
b7r6
force-pushed
the
ci/nightly-redundant-lanes
branch
from
October 3, 2026 21:05
da552fe to
7ef505e
Compare
b7r6
pushed a commit
to b7r6/nativelink
that referenced
this pull request
Oct 4, 2026
Combines TraceMachina#2877 + TraceMachina#2878 + TraceMachina#2880 on one branch so a single CI run shows the true end-state per-PR wall clock. Not for merge: the individual PRs are the review units; this exists to measure their net effect.
b7r6
pushed a commit
to b7r6/nativelink
that referenced
this pull request
Oct 4, 2026
Combines TraceMachina#2877 + TraceMachina#2878 + TraceMachina#2880 on one branch so a single CI run shows the true end-state per-PR wall clock. Not for merge: the individual PRs are the review units; this exists to measure their net effect.
Contributor
Author
|
@MarcusSorealheis I think we got those back in on Saturday, or am I conflating the pictued lanes with the ones you mean? This is the most recent run. 
|
This was referenced Oct 7, 2026
Closed
b7r6
added a commit
to b7r6/nativelink
that referenced
this pull request
Oct 7, 2026
…achina#2880) on fork main Mirrors the intended upstream per-PR layout ahead of land: Bazel Native and Cargo Native (incl. Windows) move to nightly + merge-to-main; per-PR build/test signal is carried by the Nix Bazel Dev lane. Keeps the fork representative of where upstream CI is going, not where main happens to sit today. TraceMachina#2897 retry logic preserved in native-bazel.yaml.
b7r6
added a commit
to b7r6/nativelink
that referenced
this pull request
Oct 7, 2026
Completes the no-per-PR-OCI-builds intent: image-off-pr moved image.yaml off PRs and TraceMachina#2877 moved the nix integration job off PRs, but main.yaml's integration-tests (docker-compose image build + run_integration_tests.sh) fell between them and still ran on every PR. Defer to nightly + merge-to-main, matching TraceMachina#2880's pattern. Fork-local until folded into the upstream OCI/nightly set.
b7r6
added a commit
to b7r6/nativelink
that referenced
this pull request
Oct 14, 2026
…achina#2880) on fork main Mirrors the intended upstream per-PR layout ahead of land: Bazel Native and Cargo Native (incl. Windows) move to nightly + merge-to-main; per-PR build/test signal is carried by the Nix Bazel Dev lane. Keeps the fork representative of where upstream CI is going, not where main happens to sit today. TraceMachina#2897 retry logic preserved in native-bazel.yaml.
b7r6
added a commit
to b7r6/nativelink
that referenced
this pull request
Oct 14, 2026
Completes the no-per-PR-OCI-builds intent: image-off-pr moved image.yaml off PRs and TraceMachina#2877 moved the nix integration job off PRs, but main.yaml's integration-tests (docker-compose image build + run_integration_tests.sh) fell between them and still ran on every PR. Defer to nightly + merge-to-main, matching TraceMachina#2880's pattern. Fork-local until folded into the upstream OCI/nightly set.
b7r6
force-pushed
the
ci/nightly-redundant-lanes
branch
from
October 14, 2026 17:40
4f6fdb3 to
cb1df1d
Compare
Defer CI lanes that are redundant with another per-PR lane, or expensive and non-gating, to a nightly schedule (0 7 * * * UTC) + workflow_dispatch. Per-PR keeps Bazel Dev, the install smoke test, and NativeLink's own RBE toolchain matrix; the rest runs nightly. - Cargo Native (Linux + Windows): nightly. - Cargo Dev (nix-cargo): nightly. - Integration (buildstream/buck2/mongo): nightly; core build/test covered per-PR by Bazel Dev. - Coverage: nightly + push:main (xlarge, 180-min, non-gating). Kept per-PR: Bazel Dev, installation, RBE toolchain matrix (generate-rbe-commands + rbe-toolchain), asan, Bazel Native, LRE, lints. CodeQL is a required check, left for a coordinated branch-protection follow-up.
b7r6
force-pushed
the
ci/nightly-redundant-lanes
branch
from
October 15, 2026 11:19
cb1df1d to
c05b5f6
Compare
The comment listed the integration tests among the jobs that stay on the per-PR path, but the integration job's `if` runs it only on the schedule and on demand. Name both nightly-only jobs (Cargo Dev and integration) and the ones that stay per-PR. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
This moves four lanes off pull requests to a nightly run (
0 7 * * *UTC) plusworkflow_dispatch, to cut PR latency. Each one is either covered by a lane that stays on PRs, or slow and not gating:native-cargo.yaml). PR build and test signal comes from Bazel Dev.nix-cargoinnix.yaml).buildstream,buck2andmongo*-with-nativelink-testinnix.yaml). These run real clients end to end against NativeLink.push: mainas well, so the Pages trend updates on merge. It needs an xlarge runner, can take up to 180 minutes, and gates nothing.Staying on every PR:
generate-rbe-commandsandrbe-toolchain)lre-cc,lre-rs)Jobs that stay on PRs are gated with
github.event_name != 'schedule', so the nightly run skips them.On "we cannot move all of RBE testing to nightly": the RBE toolchain matrix and LRE both stay on PRs. The integration lane also exercises NativeLink as a remote executor, for buck2 and buildstream. If that's the RBE testing you mean, I'll take it out of this PR and leave it on PRs.
CodeQL is a required status check, so moving it needs a branch-protection change. It is left alone here.
How was this verified?
The workflow files parse, and each job's
ifmatches the split above.Our fork's
mainhas run this cadence, together with #2880, since 2026-10-14. In today's scheduled run there, Cargo Native and Bazel Native passed. The Nix nightly (Cargo Dev and integration) and Coverage had not started yet when I wrote this, because the fork's runners are backed up.For scale, the slowest checks on #2910's run today were:
The combined deferral set (#2886, measured 2026-10-04) finished in 14 minutes end to end.
Risk
Low. This changes when these lanes run, not what they run. Windows cargo builds and the end-to-end integration tests would no longer run on PRs, so a break there shows up in the next nightly or on merge to
maininstead. No source, config or wire-format changes.AI assistance
Claude drafted these workflow edits and this description under my direction.