Repository navigation
ci: skip the sanitizer lane on docs-only changes - #2878
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
b7r6
changed the title
b7r6
force-pushed
the
ci/docs-paths-ignore
branch
from
October 3, 2026 20:58
833b323 to
3193142
Compare
b7r6
force-pushed
the
ci/docs-paths-ignore
branch
from
October 3, 2026 21:33
8424d5d to
d078cdd
Compare
Add '**/*.md' to paths-ignore on sanitizers so a pure-documentation PR no longer triggers the asan matrix (~12 min). paths-ignore only skips when every changed file matches, so mixed code+docs PRs still run asan.
b7r6
force-pushed
the
ci/docs-paths-ignore
branch
from
October 3, 2026 21:40
d078cdd to
177a6ad
Compare
MarcusSorealheis
approved these changes
Oct 3, 2026
b7r6
pushed a commit
to b7r6/nativelink
that referenced
this pull request
Oct 4, 2026
Combines TraceMachina#2877 + TraceMachina#2878 + TraceMachina#2880 on one branch so a single CI run shows the true end-state per-PR wall clock. Not for merge: the individual PRs are the review units; this exists to measure their net effect.
b7r6
pushed a commit
to b7r6/nativelink
that referenced
this pull request
Oct 4, 2026
Combines TraceMachina#2877 + TraceMachina#2878 + TraceMachina#2880 on one branch so a single CI run shows the true end-state per-PR wall clock. Not for merge: the individual PRs are the review units; this exists to measure their net effect.
b7r6
added a commit
to b7r6/nativelink
that referenced
this pull request
Oct 21, 2026
Bazel, Nix, LRE, coverage and the integration lane do not read markdown, so a docs-only change running them buys no coverage. TraceMachina#2878 already did this for the sanitizer lane; extend the same '**/*.md' paths-ignore to the other workflows that still carry a path filter (lre and nix on pull_request and push, coverage and main on push). Workflows that upstream left without a path filter (Bazel Native, the OCI image) or that only run on a schedule (Cargo Native) are left as they are. No '*.mdx' entry: every .mdx file lives under web/, which is already ignored. The one markdown file a build reads is nativelink-config/README.md, which is compile_data of the nativelink-config crate, but no source include_str!()s it, so it cannot change a build or test result. Co-Authored-By: Claude Opus 4.8 <[email protected]> Co-Authored-By: Claude Opus 5.5 <[email protected]>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Docs-only pull requests currently trigger the full sanitizer (asan) matrix (~12 min) because the workflow ignores only
.github/styles/**andweb/**, not Markdown. Add**/*.mdtopaths-ignoreso a pure-documentation change no longer spins up a build/test lane it cannot affect. asan stays on the per-PR path for every PR that touches code — this only skips it for docs-only changes.How was this verified?
YAML-validated.
paths-ignoreonly skips a run when every changed file matches an ignored pattern, so a PR that touches code and docs together still runs asan; only pure-docs PRs skip. The pattern was added to both thepushandpull_requesttriggers.Risk
Very low. The change only affects which events trigger the sanitizer lane; a docs-only PR skipping asan cannot regress something asan would have caught, since nothing it builds changed. Mixed PRs are unaffected. No source, config, or wire-format changes.
AI assistance
An agent (Claude Code) drafted this change and description; I reviewed every line and validated the YAML myself.