Repository navigation
Raise tesla-protocol floor to 5.0.0 - #204
Conversation
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Update protocol dependency and field allowlists pyproject.toml, tests/test_proto_coverage_lock.py |
Raises the minimum tesla-protocol version to 5.0.0. Adds allowlist entries for new VehicleAction and GetVehicleData fields. |
Priority:
Estimated code review effort: 2 (Simple) | ~7 minutes
Change: Other
Merge Risk: 
Minimal · up to f1734
-
No actionable merge-blocking risk was identified in the dependency or coverage-lock changes.
Pre-merge checks: 
5
-
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files. (1 skipped: 1 unsupported.)
-
Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
Raises the tesla-protocol floor from 3.0.0 to 5.0.0 and re-locks (uv.lock now resolves 5.0.0), which also meets the >=4.0.0 floor the aiopowerwall move needs. The protobuf floor stays at 6.33.5, which tesla-protocol 5.0.0 requires (protobuf<8,>=6.33.5). Checked against Home Assistant core dev, which pins protobuf==7.36.0; the 5.0.0 gencode stamp is 6.33.5, so it loads under that pin. The coverage lock is resynced for the new proto fields: setKeepOnCabin12vPortAction and setKeepOnCabin48vPortAction are allowlisted as a tesla-protocol 5 follow-up set (the shared keep-on mode enum needs a design and a live vehicle check), and getKeepOnAccessoryPortsState is allowlisted as an unwrapped GetVehicleData field with the same reason. dropNominalSuccessResponses needs no entry because it is outside the VehicleAction oneof that the lock visits. No other adaptation was needed: pyright strict and ruff are clean, and all 550 tests in the files that import the protobuf modules pass. No version bump.