Skip to content

Raise tesla-protocol floor to 5.0.0 - #204

Merged
Bre77 merged 1 commit into
mainfrom
fm/tfa-protocol5-bump
Oct 29, 2026
Merged

Bre77 merged 1 commit into
mainfrom
fm/tfa-protocol5-bump

Conversation

@Bre77

@Bre77 Bre77 commented Oct 29, 2026

Copy link
Copy Markdown
Member

Raises the tesla-protocol floor from 3.0.0 to 5.0.0 and re-locks (uv.lock now resolves 5.0.0), which also meets the >=4.0.0 floor the aiopowerwall move needs. The protobuf floor stays at 6.33.5, which tesla-protocol 5.0.0 requires (protobuf<8,>=6.33.5). Checked against Home Assistant core dev, which pins protobuf==7.36.0; the 5.0.0 gencode stamp is 6.33.5, so it loads under that pin. The coverage lock is resynced for the new proto fields: setKeepOnCabin12vPortAction and setKeepOnCabin48vPortAction are allowlisted as a tesla-protocol 5 follow-up set (the shared keep-on mode enum needs a design and a live vehicle check), and getKeepOnAccessoryPortsState is allowlisted as an unwrapped GetVehicleData field with the same reason. dropNominalSuccessResponses needs no entry because it is outside the VehicleAction oneof that the lock visits. No other adaptation was needed: pyright strict and ruff are clean, and all 550 tests in the files that import the protobuf modules pass. No version bump.

@coderabbitai

coderabbitai Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 6ea002b and f173414.

Files ignored due to path filters: 1
  • uv.lock is excluded by !**/*.lock
Files selected for processing: 2
  • pyproject.toml
  • tests/test_proto_coverage_lock.py

Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour.

Walkthrough

The minimum tesla-protocol version changes from 3.0.0 to 5.0.0. The coverage lock adds allowlist entries for fields introduced in that version.

Changes: Protocol dependency and coverage lock

Layer / File(s) Summary
Update protocol dependency and field allowlists
pyproject.toml, tests/test_proto_coverage_lock.py
Raises the minimum tesla-protocol version to 5.0.0. Adds allowlist entries for new VehicleAction and GetVehicleData fields.

Priority: Normal

Estimated code review effort: 2 (Simple) | ~7 minutes

Change: Other

Merge Risk: Minimal · up to f1734

No actionable merge-blocking risk was identified in the dependency or coverage-lock changes.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly and concisely identifies the main change: raising the tesla-protocol dependency floor to 5.0.0.
Description check Passed The description accurately explains the dependency update, lockfile resolution, coverage-lock changes, compatibility details, and validation results.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files. (1 skipped: 1 unsupported.)

Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@Bre77
Bre77 merged commit 851fc8c into main Oct 29, 2026
7 checks passed
@Bre77
Bre77 deleted the fm/tfa-protocol5-bump branch October 29, 2026 10:38
@Bre77 Bre77 mentioned this pull request Oct 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant