Re-pin the Flathub manifest to v5.1.0 - #13895
Merged
Merged
Conversation
The Flathub-ready manifest still pointed at the v5.0.0 tag, two stable releases behind the current stable. Nothing consumes this pin yet (the app is not submitted, see #11800), but CI's build-linux-flathub job builds whatever it names, so validating the submission candidate meant validating a stale one. Only the source pin moves. nuget-sources.json stays uncommitted by design, regenerated from the pin by regenerate-flathub-nuget-sources. Co-Authored-By: Claude Opus 5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
installer/flatpak/flathub/dk.nikse.subtitleedit.yamlstill pinnedv5.0.0/a44ffa70. Current stable isv5.1.0, so the submission candidate CI validates was two stable releases behind.Moves the source pin only:
tag: v5.0.0→v5.1.0commit: a44ffa70…→38f1dd4bac6c70bdf1f2d1bb5952aa414c6cb777(thev5.1.0tag object, confirmed againstorigin)nuget-sources.jsonstays uncommitted, per the folder README —regenerate-flathub-nuget-sourcesrecreates it from whatever the manifest pins, so it can't drift.Known follow-up, not fixed here
The flathub manifest builds from the pinned tag's checkout, so the AppStream metainfo in the bundle is v5.1.0's copy of the file — and that copy's newest
<release>is still5.0.0(2026-06-22). Editing the metainfo onmaincannot fix this; it needs a 5.1.0 entry present at a commit we pin. Worth sorting before the actual Flathub submission (#11800), but it does not block the validation build.Refs #11800.
🤖 Generated with Claude Code