feat(sidebar): split DRAFTs into their own "N drafts will be groomed" row - #116
Open
ArgonQQ wants to merge 1 commit into
Open
feat(sidebar): split DRAFTs into their own "N drafts will be groomed" row#116ArgonQQ wants to merge 1 commit into
ArgonQQ wants to merge 1 commit into
Conversation
… row (t-1cdb) DRAFTs have no groomed story yet, so lumping them into "N proposals to approve" invited a human to approve work that was never groomed. computeBadge now splits newCount (groomed New tasks) from draftCount (ungroomed DRAFTs); the aggregate badge count is unchanged. Adds the `is:draft` reserved search token so the new sidebar row can filter the New tab to just drafts.
Contributor
|
📦 Build succeeded — installable loopboard-todo-1cdb-draft-sidebar-count.vsix Download from the run's Artifacts, unzip, then install: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
computeBadgenow splitsnewCount(groomed New tasks) from a newdraftCount(ungroomed DRAFTs) instead of lumping DRAFTs into "N proposals to approve" — the aggregatebadge.countis unchanged.is:draftreserved search token.test/view.test.jsupdated for the new split semantics plus a case asserting drafts and groomed New tasks don't double-count.Closes t-1cdb.
Test plan
make check(build + test) green — 118/118 tests pass