Repository navigation
DEV-1358: MATLAB update PR asks for a hardware check and says merging releases - #340
Merged
Merged
Conversation
The update-matlab job's PR now asks for a MATLAB example to be run on a Shimmer3 and a Shimmer3R before merging, and says that merging publishes a MATLAB API release (Shimmer-MATLAB-ID's new release.yml). The how-to-release steps in release.yml, its step summary and AGENTS.md say the same. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
update-matlabjob opens an "Update ShimmerJavaClass.jar" PR in Shimmer-MATLAB-ID. That PR's text now adds two things, as LabVIEW's update PR does for its VIs:plotandwriteexample.mon a Shimmer3 and a Shimmer3R. MATLAB cannot run in CI.The how-to-release steps at the top of
release.yml, the release job's step summary andAGENTS.mdnow say the same.Depends on ShimmerResearch/Shimmer-MATLAB-ID#21, which adds the release workflow there. Merge that first, or the new PR text describes a release that doesn't happen yet.
Tested: the YAML parses. I ran the
update-matlabscript locally withghandgitstubbed, and the PR body renders as:The workflow's own dry run on this PR covers
buildandmatlab-jar.update-matlabruns only on a real release.🤖 Generated with Claude Code