Repository navigation
DEV-1357: say up front that a release needs a passing hardware test - #227
Merged
Merged
Conversation
PublishNuGet's header now opens with numbered "How to release" steps, as Release Java API's does: step 0 is the bench HIL, without which the release does not proceed (or a Jira key in hil_waiver), and the last step is trying the example VIs on a Shimmer3 and a Shimmer3R before merging the LabVIEW PR, which publishes the LabVIEW release. The old "Hardware test gate" paragraph is folded into step 0. The publish job now writes a run summary like the Java release's: the release, the NuGet packages, the hardware test result, and the next step. AGENTS.md says the same. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DEV-1357 follow-up. This does for the C# release what ShimmerResearch/Shimmer-Java-Android-API#340 did for the Java one, and makes the hardware test gate the first thing a reader sees.
The change
PublishNuGet.ymlheader: it now opens with numbered "How to release" steps, laid out like Release Java API's:tools/hil/run-csharp-hil.ps1 -Report, which postscsharp-hil). It says the release does not proceed without it: the build job stops before building unless that status passed for the commit, orhil_waivergives a Jira key.The old "Hardware test gate" paragraph at the bottom is folded into step 0. The pull-request line now also says PR runs skip the hardware test check, which they already did.
Run summary: the publish job now writes one, as the Java release does. It gives the release link, the NuGet packages, the hardware test result (or the waiver), and the next step: the LabVIEW PR to check and merge.
update-labview's own summary, with the link to the LabVIEW run, follows it.AGENTS.md: step 1 says the release does not proceed withoutcsharp-hil. Step 3 says LabVIEW cannot run in CI.Not changed
update-labvieware as DEV-1357: start the LabVIEW wrapper update from the C# release #226 left them.Tested
This PR's own build checks the workflow still parses. The new summary lines only run on a real release, so they get their first run at the next one.
🤖 Generated with Claude Code