Skip to content

test: remove duplicate Pareto ordering probes / test: 删除重复的 Pareto 顺序测试 #1231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
functionstackx merged 1 commit into from
Sep 29, 2026
Merged

test: remove duplicate Pareto ordering probes / test: 删除重复的 Pareto 顺序测试 #1231

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 0 additions & 57 deletions packages/app/src/lib/chart-utils.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,63 +466,6 @@ describe('getNestedYValue', () => {
});
});

// ---------------------------------------------------------------------------
// Pareto front x-ordering — gradient labels require ascending x
// ---------------------------------------------------------------------------
describe('paretoFront x-ordering for gradient labels', () => {
it('paretoFrontUpperRight returns points in ascending x order', () => {
const points = [pt(3, 30), pt(1, 10), pt(2, 20)];
const front = paretoFrontUpperRight(points);
for (let i = 1; i < front.length; i++) {
expect(front[i].x).toBeGreaterThanOrEqual(front[i - 1].x);
}
});

it('paretoFrontLowerRight returns points in descending x order', () => {
// This is the documented behavior that causes gradient labels to break
// when points are not re-sorted to ascending x.
// Use data where y decreases as x decreases so multiple points land on front:
// lower_right: sort desc x, push when y < minY
const points = [pt(3, 20), pt(2, 15), pt(1, 10)];
const front = paretoFrontLowerRight(points);
expect(front.length).toBeGreaterThanOrEqual(2);
// Verify descending order
for (let i = 1; i < front.length; i++) {
expect(front[i].x).toBeLessThanOrEqual(front[i - 1].x);
}
});

it('paretoFrontLowerRight sorted ascending fixes gradient label compatibility', () => {
// Regression test: sorting the output of paretoFrontLowerRight by
// ascending x ensures computeGradientStops gets a positive totalRange.
const points = [pt(3, 20), pt(2, 15), pt(1, 10)];
const front = paretoFrontLowerRight(points);
expect(front.length).toBeGreaterThanOrEqual(2);
// Apply the fix from ScatterGraph.tsx
front.sort((a, b) => a.x - b.x);
// Now ascending
for (let i = 1; i < front.length; i++) {
expect(front[i].x).toBeGreaterThanOrEqual(front[i - 1].x);
}
});

it('paretoFrontUpperLeft returns points in ascending x order', () => {
const points = [pt(3, 10), pt(1, 30), pt(2, 20)];
const front = paretoFrontUpperLeft(points);
for (let i = 1; i < front.length; i++) {
expect(front[i].x).toBeGreaterThanOrEqual(front[i - 1].x);
}
});

it('paretoFrontLowerLeft returns points in ascending x order', () => {
const points = [pt(3, 30), pt(1, 10), pt(2, 20)];
const front = paretoFrontLowerLeft(points);
for (let i = 1; i < front.length; i++) {
expect(front[i].x).toBeGreaterThanOrEqual(front[i - 1].x);
}
});
});

// ===========================================================================
// getHardwareKey
// ===========================================================================
Expand Down
Loading