test: remove duplicate Pareto ordering probes / test: 删除重复的 Pareto 顺序测试 - #1231
Merged
Merged
Conversation
中文:删除五个重复、空断言或仅验证测试内排序的用例,保留各方向的精确前沿结果与渲染覆盖。
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
4 tasks
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Delete five low-value tests from the
paretoFront x-ordering for gradient labelsblock inpackages/app/src/lib/chart-utils.test.ts.57 test lines deleted; no production code, Pareto algorithm, UI/API behavior, browser spec, fixture, or timing-inventory changes. This is separate from the already merged InferenceTable cleanup in #1230.
Companion E2E cleanup: InferenceX #3574. Both PRs are independently mergeable.
handles unsorted input (sorts by x ascending internally)test asserts the complete ordered frontier.handles unsorted inputand ideal-staircase cases assert exact members and order..sort()inside the test rather than exercising the chart's fix. Exact frontier tests remain, along with the gradient helper suite and rendered cost/energy gradient browser cases.handles unsorted inputcase asserts the complete ordered result.No assertions need transferring for this batch. All algorithm-specific numerical, boundary, missing-data and rendering tests remain. The separate obsolete cost-filter candidate is not included.
Validation
--maxWorkers=1, without changing any timeout or test.git diff --checkpassed.E2E_FIXTURES=1server but exceeded the 360-second command limit during integration tests. It is incomplete, not a pass. Full browser validation remains a CI gate.cypress/e2e/gradient-labels.cy.ts, subsequently passed all 16 tests against the same fixture server.reviewer_unavailable/engine_failedwithout a report. The independent review is a fallback, not a successful Codex run.AI model disclosure
PR creation only; no merge requested.
中文说明
删除
chart-utils.test.ts中五个低价值测试,共减少 57 行。生产代码、Pareto 算法、UI/API 行为、浏览器测试、fixture 和分片耗时清单均未改动。本次与已合并的 #1230 表格测试清理独立。对应的 E2E 清理见 InferenceX #3574,两个 PR 可独立合并。
三个顺序探测由各算法已有的精确结果测试覆盖;一个测试只验证在测试内部复制的
.sort(),没有执行图表中的修复;另一个 LowerLeft 测试实际只返回一个点,循环内没有执行任何断言。保留完整有序前沿、单点边界、数值行为、gradient helper 及 cost/energy 图表渲染测试,无需迁移断言。基线各工作区测试汇总通过:app 6,009、constants 63、DB 831、MCP 25、skills 351,app 跳过四项;命令包装器在汇总写入后超时。修改后的 app 全量运行有 6,000 项通过、四项跳过,并在三个未修改的本地化文件中出现四个五秒超时。随后以单 worker 重跑这三个文件及三个图表相关文件,311 项全部通过,未放宽超时或修改测试。
修改后的 constants 63 项、DB 831 项、MCP 25 项通过,typecheck、目标文件 lint/format 和差异检查通过。已尝试本地浏览器 smoke,但 integration 阶段超过 360 秒限制,不能视为通过;完整浏览器验证仍交由 CI。
随后针对保留的
cypress/e2e/gradient-labels.cy.ts运行浏览器验证,16 项全部通过。独立覆盖保全审查未发现 P0–P2 问题或唯一行为覆盖缺失。Codex autoreview 返回
reviewer_unavailable/engine_failed,未生成报告;独立审查是替代审查。AI 模型:GPT 6 Astra Fast 负责实现、验证与 PR 编写;只读发现 agent 和独立覆盖审查 agent 的精确模型名称或版本未由运行环境提供,无法核实。本 PR 保持未合并。