[DO NOT REVIEW] Revert #5201 null-as-miss; drop null problem-cache sentinels on load (gpuep-rel-2610) - #5208
Merged
tperry-amd merged 2 commits intoAug 27, 2026
Conversation
A null mark() sentinel is a transient in-run 'benchmark in progress' signal that compile_ops relies on to benchmark a repeated problem only once. It must not be persisted: a shipped or stale null that is re-loaded makes the op skip forever, leaving it unresolved (0xC0000005 / 'No valid tuned compilation', AIRADSW-871). Drop null sentinels at the load boundary in the json and sqlite backends so a persisted null cannot come back, while the in-run dedup (get()/compile_ops) is unchanged. Also guards is_module_fusible against a null or non-string solution. Updates the backend round-trip tests (a sentinel no longer survives save/load). Co-authored-by: Uros Petkov <[email protected]> Signed-off-by: danieyan-amd <[email protected]>
tperry-amd
merged commit Aug 27, 2026
1217ce1
into
gpuep-releases/gpuep-rel-2610
15 of 18 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #5201 (already merged into
gpuep-rel-2610) and replaces it with the load-boundary fix.Why revert #5201
#5201 fixed the shipped-null crash by treating a null cache entry as a miss. But a null
mark()sentinel is a transient in-run dedup signal:compile_opsbenchmarks a repeated problem once (the first instance marks it; duplicates see the null and skip). Treating it as a miss removes that dedup, so a repeated problem is benchmarked once per instruction instead of once (raised in review on the develop counterpart #5204).The fix (2nd commit)
Keep the in-run dedup (
get()/compile_opsunchanged from the original) and instead drop null sentinels at the load boundary in the json and sqlite backends. A persisted or shipped null can no longer come back, so it cannot cause the original skip-and-crash (AIRADSW-871), and repeated problems are still benchmarked once. Theis_module_fusiblenull/non-string guard from #5201 is kept.This is the release counterpart of develop #5204, which is build- and test-verified (reduced MLIR-off gfx1100 build, all four problem-cache test binaries pass). Not built on this box (the 2610 build needs MIOpen); CI validates here.
Commits