Unable to optimize SDXL model pipeline on Amuse App - #5198
Closed
tamahedi wants to merge 1 commit into
Closed
Conversation
…ution.if_string() returns nullptr when no tuning data exists for the target GPU (e.g. gfx1201).
Collaborator
|
Can a verify test be added that reproduces this issue? |
Contributor
Author
|
I tried out this PR #5208 which got merged to our branch where we build from and the issue was resolved. For now we don't need this but if for some reason it didn't work out I'll reopen it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
MIGraphX crashes with ACCESS_VIOLATION (0xC0000005) during SDXL Unet optimization on gfx1201/Navi48. is_module_fusible() calls solution.if_string() which returns nullptr when no tuning entry exists for the target architecture, and the result is dereferenced without a null check. This blocks all MIGraphX inference on untuned GPU targets.
Technical Details
In src/targets/gpu/mlir.cpp, is_module_fusible() assumes solution.if_string() always returns a valid pointer. On GPUs without tuning data (gfx1201), the solution value is not a string type (shows null), so if_string() returns nullptr. The subsequent dereference causes a null pointer access violation in migraphx_gpu!is_module_fusible.
Changelog Category
Add a
CHANGELOG.mdentry for any option other thanNot ApplicableFollow the LLVM AI Tool Use Policy for contributions using AI.