Skip to content

fix(ui): export and copy menu buttons have one chevron #1437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ZhuchkaTriplesix merged 1 commit into from
Oct 11, 2026
Merged

fix(ui): export and copy menu buttons have one chevron #1437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/features/extensions/extension_table_toolbar.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ class ExtensionTableToolbar extends material.StatelessWidget {
if (onCopyFormat != null) ...[
const Gap(4),
ExportMenuButton(
label: 'Copy ▾',
label: 'Copy',
icon: material.Icons.copy_rounded,
isSave: false,
onSelected: onCopyFormat!,
Expand All @@ -158,7 +158,7 @@ class ExtensionTableToolbar extends material.StatelessWidget {
if (onSaveFormat != null) ...[
const Gap(4),
ExportMenuButton(
label: 'Export ▾',
label: 'Export',
icon: material.Icons.file_download_outlined,
isSave: true,
onSelected: onSaveFormat!,
Expand Down
4 changes: 2 additions & 2 deletions lib/features/workspace/results_tab.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -495,14 +495,14 @@ class _ResultsTabState extends material.State<ResultsTab> {
const Gap(8),

ExportMenuButton(
label: 'Export ▾',
label: 'Export',
icon: material.Icons.copy_rounded,
isSave: false,
onSelected: (format) => unawaited(_copyAs(format)),
),
const Gap(6),
ExportMenuButton(
label: 'Save File ▾',
label: 'Save File',
icon: material.Icons.download_rounded,
isSave: true,
onSelected: (format) {
Expand Down
2 changes: 1 addition & 1 deletion test/features/workspace/generic_table_view_export_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ void main() {
}

Future<void> copyAs(WidgetTester tester, String menuLabel) async {
await tester.tap(find.text('Export ▾'));
await tester.tap(find.text('Export'));
await tester.pump();
await tester.pump(const Duration(milliseconds: 500));
await tester.tap(find.text(menuLabel));
Expand Down
6 changes: 3 additions & 3 deletions test/features/workspace/results_tab_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1122,7 +1122,7 @@ void main() {
buffer.dispose();
});

testWidgets('ResultsTab renders Export ▾ button with file export options', (tester) async {
testWidgets('ResultsTab renders Export button with file export options', (tester) async {
final rows = [
['1', 'Alice'],
];
Expand All @@ -1143,8 +1143,8 @@ void main() {
);
await tester.pumpAndSettle();

expect(find.text('Export ▾'), findsOneWidget);
expect(find.text('Save File ▾'), findsOneWidget);
expect(find.text('Export'), findsOneWidget);
expect(find.text('Save File'), findsOneWidget);
});

testWidgets('ResultsTab toggles filter bar and closes it when close button or Escape is triggered', (tester) async {
Expand Down
Loading