Repository navigation
test(guards): lib/shared must not import shadcn_flutter (ratchet allow-list) - #1409
Merged
Merged
Conversation
Fix the current set of files that import it in an allow-list: nothing new may start to, and an entry must be removed in the change that removes its import. Part of #1365.
github-actions
Bot
added
epic
It only mentions the package in a comment; it does not import it.
This was referenced Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1365 (does not close it)
What
test/guards/shared_does_not_import_shadcn_test.dart, in the style of the other guards, written as a ratchet:lib/shared/is scanned; a file that importspackage:shadcn_flutter/and is not in the allow-list fails the test.lib/shared/widgets/including thewidgets.dartbarrel that re-exports shadcn, plusservices/data_export_service.dart).docs/ui-kit.md's guard table lists it.Why now
Epic #1331 / #1365 migrate away from shadcn in many PRs. Without a ratchet the count can grow in between; with it, every migration PR only has to delete lines from one list.
Not in this PR
No source changes: the imports themselves go in the component migrations (
QueryaButtonis #1408, the controls follow).Not run locally; CI is the check.