Repository navigation
refactor(ui): QueryaEmptyState on QueryaButton, off shadcn - #1419
Merged
Merged
Conversation
The default action is a secondary QueryaButton (sm when compact, lg otherwise), gaps are SizedBoxes and the scheme comes from context.colors. The file leaves the shadcn allow-list. Part of #1365.
github-actions
Bot
added
epic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1365 and #1331 (closes neither)
Small migration under the ratchet guard (#1409), using
QueryaButton(#1408).QueryaEmptyState(actionLabel+onAction) is aQueryaButton.secondary:smwhencompact,lgotherwise (empty-state actions arelgin the standard). It was shadcn'sOutlineButton.Gap->SizedBox, the colour scheme fromcontext.colors; noshadcn_flutterimport, the file leaves the allow-list.action,actionLabel,onAction,compact) is unchanged, so the ~20 call sites need nothing.No existing test asserts a shadcn button type for this widget; they find texts and taps.
Why not
QueryaActionButtontooIt takes shadcn's
ButtonSizein its public API and has call sites that passButtonSize.small; it is swapped file by file during the toolbar migration (#1337), not here.Not run locally; CI is the check.