Repository navigation
test(redis): isolated tests for the type-specific editors - #1098
Merged
Merged
Conversation
…test-hang' into issue/1040-nosql-tests
…test-hang' into issue/1040-nosql-tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
test/features/redis/redis_type_editors_test.dart: isolated widget tests for the editors extracted in #1034 (RedisStringEditor,RedisHashEditor,RedisListEditor,RedisSetEditor,RedisZsetEditor), driven by plain callbacks without a connection.HSETtrims the field name but keeps the value and clears the inputs, an empty field name is ignored, delete reports the field, read-only hides the add bar and delete icons, empty state and footer.RPUSH(sent as typed, empty ignored), editing sendsLSETwith the value the item had (concurrency guard input), cancel / unchanged text sends nothing, delete reports index and item, binary items get a badge and no edit icon, read-only, empty state.SADDtrims and ignores blanks, delete, read-only, empty state.ZADDparses the score and trims the member, an empty member or a non-numeric score is ignored, delete, read-only.Coverage of the rest of #1040
Most of the listed suites already exist and are not duplicated here: Mongo view modes (
mongo_documents_view_modes_test), aggregation (mongo_aggregation_stage_test,mongo_aggregation_workspace_test), indexes (mongo_indexes_view_test,mongo_index_info_test), MQL console (mongo_query_workspace_test,mql_parser_test), Redis key tree (redis_key_tree_engine_test) and CLI (redis_cli_workspace_test).Still open: the Mongo collection tree suite (#1023). The tree widgets are private parts of
ConnectionsPaneland need a Mongo connection fake, so that is a separate, larger piece.Written without running locally; CI is the first run.
Refs #1040