Repository navigation
test(workspace): skip the hanging selection test, cap workspace suites at 60s - #1100
Merged
Merged
Conversation
…ds, per-test 60s timeouts Starting execute inside runAsync and awaiting it hung CI. Follow the pattern used by the extension workspace tests: start the action in the test zone, give pending SQLite I/O real time, then pump so the continuation runs. Each testWidgets now has an explicit 60s timeout (the library-level @timeout is overridden by testWidgets' own default).
Tests and analysis pick their runner from the CI_RUNS_ON repository variable (default ubuntu-latest); pull requests from forks always use GitHub-hosted runners. Add scripts/ci/setup-runner.sh to prepare a machine and register runners, and docs/ci-runners.md.
ci: run tests and analysis on self-hosted runners, builds stay on GitHub
…shortcuts-test-hang
…rs, wait for export menu
…fix/generic-workspace-shortcuts-test-hang
Closed
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI on #1097, #1098 and #1099 hangs for the 10-minute test timeout on
generic_sql_workspace_shortcuts_test.dart: only the selected text runs when there is a selection(added in #1096), which blocks every PR.EditableTextState. I could not reproduce the hang locally, so the cause is not confirmed.sessions,shortcuts,history) get@Timeout(Duration(seconds: 60)), so a hang in any of them fails in a minute instead of blocking CI for ten.