Repository navigation
Extension template: same toolbar setup as the PyMoDAQ extensions - #59
Merged
Merged
Conversation
…ar, as in the PyMoDAQ extensions Co-Authored-By: Claude Sonnet 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01Tdiso1u1ZhikSutj2Qs5Cg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: the extension template called
super().__init__(parent, dashboard), so the extension's own toolbar was created withadd_toolbar_break=True(the default ofCustomApp.__init__,pymodaq_gui/utils/custom_app.py:130), while the extensions of PyMoDAQ (scan, sequencer, ramping, data mixer, logger, PID) passadd_toolbar_break=False.AGENTS.mddid not say that an extension has two toolbars.After: the template passes
add_toolbar_break=Falseand comments on the two toolbars (the extension's own, created by the base class, and the Dashboard one fromcreate_dashboard_toolbar(add_break=False)).AGENTS.mddescribes both.How: compared with the
__init__of the core extensions. TheConsoleextension is the exception: it does not pass the argument. Template tests (17) pass andcheck_extensionreports nothing on the template extension.🤖 Generated with Claude Code
https://claude.ai/code/session_01Tdiso1u1ZhikSutj2Qs5Cg
Generated by Claude Code