Repository navigation
feat(infra): update the deployment script - #163
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
GitHub Actions
Error
vprashrex
left a comment
vprashrex
left a comment
There was a problem hiding this comment.
Approved but added one major comment > The workflow name should be "Kaapi Guardrails CI", not "Kaapi CI". Otherwise this deploy won't trigger on merge.
| --arg url "$RUN_URL" --argjson fields "$fields" \ | ||
| '{embeds:[{title:$title,url:$url,color:$color,fields:$fields,timestamp:(now|todate)}]}') | ||
| curl -sf -H "Content-Type: application/json" -X POST -d "$payload" "$DISCORD_WEBHOOK_URL" \ | ||
| || echo "Discord notification failed to send" |
There was a problem hiding this comment.
Can we use exit 1 if the webhook notification fails and include a reason indicating that the webhook failed?
|
|
||
| on: | ||
| workflow_run: | ||
| workflows: ["Kaapi CI"] |
There was a problem hiding this comment.
suggestion use this
workflows: ["Kaapi Guardrails CI"]
there is no Kaapi Ci workflow name in this repo, the only Ci workflow name in this repo is Kaapi Guardrails CI
3 participants
Summary
Staging Deployment Script
Kaapi Guardrails CIfinishes onmain, not on every push.main(PR runs are skipped).git reset --hard <sha>on the server instead oforigin/main).workflow_dispatch).aws ssm waitand a 10-minute timeout.Production Deployment Script
verify-cijob: ifKaapi Guardrails CIdidn't pass on the tagged commit, the release stops.deployruns only afterverify-cipasses.ref(it usedrelease.tag_name, which is empty when a tag is pushed).aws ssm waitand a 15-minute timeout.Before submitting a pull request, please ensure that you mark these task.
fastapi run --reload app/main.pyordocker compose upin the repository root and test.