Skip to content

chore: gate legacy stores behind a feature flag #624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
milindsrivastava1997 merged 1 commit into from
Aug 26, 2026
+7 −0
Merged

chore: gate legacy stores behind a feature flag #624

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions asap-query-engine/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ criterion = { version = "0.5", features = ["html_reports"] }
[[bench]]
name = "simple_store_bench"
harness = false
required-features = ["legacy_stores"]

[features]
#default = ["lock_profiling", "extra_debugging"]
Expand All @@ -97,3 +98,8 @@ jemalloc = ["dep:tikv-jemallocator"]
lock_profiling = []
# Enable extra debugging output
extra_debugging = []
# Legacy SimpleMapStore implementations, kept only for the simple_store_bench
# comparison benchmark. Off by default so the Store trait's real implementors
# are just SimpleMapStoreGlobal/PerKey — adding a Store trait method doesn't
# require updating the legacy variants.
legacy_stores = []
1 change: 1 addition & 0 deletions asap-query-engine/src/stores/simple_map_store/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
mod common;
pub mod global;
#[cfg(feature = "legacy_stores")]
pub mod legacy;
pub mod per_key;

Expand Down
Loading