chore: gate legacy stores behind a feature flag - #624
Merged
Conversation
Legacy SimpleMapStoreGlobal/PerKey implement the Store trait but are only used by the simple_store_bench comparison benchmark. Gating them behind an off-by-default legacy_stores feature means future Store trait changes don't need to touch the legacy variants.
milindsrivastava1997
changed the title
milindsrivastava1997
added a commit
that referenced
this pull request
Aug 26, 2026
…627) * wip(query-engine): batched exact-window store query (#609) Checkpoint before merging main (legacy stores gated behind feature flag in #624). Not yet wired into scan_windows_via_exact; no tests yet. * wip(query-engine): wire batched exact-window query into scan_windows_via_exact (#609) Checkpoint before rebasing onto main (legacy stores removed in #625). * fix(query-engine): restore lock_profiling on batch exact-query, dedupe per_key/global Addresses review feedback on #609's batch method: - per_key.rs and global.rs had dropped the lock_profiling wait/hold-time instrumentation that the single-window path has, on exactly the path now most affected by longer lock hold times. - The per-window epoch-resolution loop (current_epoch/sealed_epochs lookup, read-count bookkeeping) was copy-pasted between the two backends. Extracted into common::resolve_exact_windows, shared by both.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LegacySimpleMapStoreGlobal/LegacySimpleMapStorePerKeyimplement theStoretrait but are only exercised by thesimple_store_benchcomparison benchmark — no production code path uses them.legacy_storesCargo feature; gatedpub mod legacy;behind it and made the bench target require it (required-features).cargo build/check/testno longer compiles the legacyStoreimpls, so future changes to theStoretrait don't need to touch the legacy variants. Runcargo bench --features legacy_storeswhen the comparison benchmark is actually needed.Test plan
cargo check -p query_engine_rust(default features) builds cleancargo check -p query_engine_rust --benches --features legacy_storesbuilds cleancargo check -p query_engine_rust --benches(default features) skips the bench target with no error