refactor(web-analytics): extract search and ai query builders by jordanm-posthog · Pull Request #123196 · PostHog/posthog

jordanm-posthog · 2026-10-25T17:24:49Z

Problem

The page reports directory needs the Search & AI query builders, but they live inside pagePerformanceLogic.

Part 4 of 12 in the page reports stack, behind the web-analytics-page-reports-directory flag. Follows #123074.

Changes

No visible change. This PR only moves code.
The window, path and breakdown builders move from pagePerformanceLogic.ts to searchAndAiQueries.ts.
The logic, the breakdown modal and the metric cell import them from there.

How did you test this code?

The existing pagePerformanceLogic tests, with their imports updated.

Release status

No feature flag controls this change

Docs update

None.

🤖 Agent context

Autonomy: Human-driven (agent-assisted)

Agent: Claude Code, Opus 5.5 (claude-opus-5-5)

Skills invoked: /simplify, /stacking-prs, /writing-pr-descriptions.

trunk-io · 2026-10-25T17:24:54Z

😎 This pull request was merged.

github-actions · 2026-10-25T17:26:16Z

🤖 CI report

✅ Trunk lane — non-backend lane

This PR is assigned to the non-backend lane. It does not run backend Python tests and may merge in parallel with PRs in other lanes.

⚠️

Complexity (TypeScript) — 5 functions above the limit (max 27)

Cyclomatic complexity above the limit in changed typescript files (10 for production files, 15 for test files). Warn only: worth simplifying when you next touch these functions.

Function	Location	Complexity	Limit
`SearchAndAiMetricCell`	`products/web_analytics/frontend/searchAndAi/SearchAndAiMetricCell.tsx:35`	27	10
`loadOverview`	`frontend/src/scenes/web-analytics/pagePerformanceLogic.ts:1167`	16	10
`resolvePagePerformanceWindow`	`products/web_analytics/frontend/searchAndAi/searchAndAiQueries.ts:54`	13	10
`parsePagePerformanceOverviewResponse`	`frontend/src/scenes/web-analytics/pagePerformanceLogic.ts:256`	12	10
`resolvePagePerformanceDataState`	`frontend/src/scenes/web-analytics/pagePerformanceLogic.ts:215`	11	10

✅ Duplication (Python) — clean

New Python code duplication introduced by this branch. Fails at 70+ tokens in app code, or 150+ tokens when both copies live in test files. Advisory while the gate proves itself: extract a shared helper instead of copying.

✅ Duplication (TypeScript) — clean

New TypeScript code duplication introduced by this branch. Fails at 70+ tokens in app code, or 150+ tokens when both copies live in test files. Advisory while the gate proves itself: extract a shared helper instead of copying.

✅ Bundle size — no change

Uncompressed size of every built .js bundle, compared against the base branch.

Total: 76.61 MiB · no change

No file changed by more than 1000 B.

_{Posted automatically by build-bundle-size-report · uncompressed bytes from dist-report}

✅ Eager graph — within budget

How much code each root ships on the eager path — downloaded and parsed before the surface is interactive. Measured from the esbuild output chunks (post-tree-shake, static imports only); lazy import() / React.lazy chunks are not counted.

Root	Eager (shipped)	Δ vs base	Budget
entry (logged-out pages, app bootstrap) `src/index.tsx`	1019.4 KiB · 24 files	no change	`█████████░` 87.0% of 1.14 MiB
logged-out boot: index + App + bootApp (preloaded by every page, including /login) `src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts`	2.95 MiB · 620 files	no change	`██████████` 97.4% of 3.03 MiB
authenticated shell (every logged-in page) `src/scenes/AuthenticatedShell.tsx`	7.44 MiB · 2,549 files	no change	`██████████` 99.2% of 7.50 MiB
dashboard scene `src/scenes/dashboard/Dashboard.tsx`	9.89 MiB · 3,716 files	no change	`██████████` 98.8% of 10.01 MiB
today home path `src/scenes/AuthenticatedShell.tsx + src/scenes/project-homepage/ProjectHomepage.tsx + src/scenes/project-homepage/today/TodayHome.tsx`	7.61 MiB · 2,641 files	no change	`██████████` 98.4% of 7.74 MiB
AI-first home path `src/scenes/AuthenticatedShell.tsx + src/scenes/project-homepage/ProjectHomepage.tsx + src/scenes/project-homepage/ai-first/AiFirstHomepage.tsx`	7.86 MiB · 2,633 files	no change	`██████████` 99.4% of 7.91 MiB
events scene `src/scenes/activity/explore/EventsScene.tsx`	9.34 MiB · 3,503 files	no change	`██████████` 97.4% of 9.59 MiB
web analytics scene `src/scenes/web-analytics/WebAnalyticsScene.tsx`	10.25 MiB · 3,736 files	🔺 +12 B (+0.0%)	`█████████░` 94.6% of 10.83 MiB
replay detail scene `src/scenes/session-recordings/detail/SessionRecordingDetail.tsx`	8.38 MiB · 3,084 files	no change	`█████████░` 88.5% of 9.47 MiB

🟢 node_modules/monaco-editor/ stays out of src/index.tsx
🟢 src/lib/components/ActivityLog/describers stays out of src/index.tsx
🟢 node_modules/@posthog/brand/dist/generated/hoggies/svg/ stays out of src/index.tsx
🟢 node_modules/@posthog/brand/dist/generated/hoggies/components/ stays out of src/index.tsx
🟢 node_modules/monaco-editor/ stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/layout/navigation-3000/navigationLogic.tsx stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/scenes/dashboard/dashboardLogic.tsx stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/lib/lemon-ui/LemonMarkdown/ stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/lib/components/RichContentEditor/ stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/lib/components/CodeSnippet/ stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/taxonomy/core-filter-definitions-by-group.json stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 node_modules/zod/ stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/scenes/billing/billingLogic.tsx stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/lib/components/ProductEmptyState/productSetupPreloadLogic.ts stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 node_modules/monaco-editor/ stays out of src/scenes/AuthenticatedShell.tsx
🟢 src/lib/components/ActivityLog/describers stays out of src/scenes/AuthenticatedShell.tsx
🟢 products/dashboards/frontend/widgets/previews/ stays out of src/scenes/AuthenticatedShell.tsx
🟢 src/scenes/session-recordings/player/sessionRecordingPlayerLogic.ts stays out of src/scenes/AuthenticatedShell.tsx
🟢 products/wizard/frontend/runs/WizardRunDetailsDrawer.tsx stays out of src/scenes/AuthenticatedShell.tsx
🟢 src/layout/today/TodayShell.tsx stays out of src/scenes/AuthenticatedShell.tsx
🟢 src/layout/today/TodayContextPanelFloating.tsx stays out of src/scenes/AuthenticatedShell.tsx
🟢 src/layout/today/TodaySidePanel.tsx stays out of src/scenes/AuthenticatedShell.tsx
🟢 src/layout/today/TodayTopBar.tsx stays out of src/scenes/AuthenticatedShell.tsx
🟢 src/layout/today/todayRailItems.tsx stays out of src/scenes/AuthenticatedShell.tsx
🟢 zod/v4/locales/de.js stays out of src/scenes/AuthenticatedShell.tsx
🟢 node_modules/@posthog/brand/dist/generated/hoggies/svg/ stays out of src/scenes/AuthenticatedShell.tsx
🟢 node_modules/@posthog/brand/dist/generated/hoggies/components/ stays out of src/scenes/AuthenticatedShell.tsx
🟢 src/scenes/session-recordings/playlist/SessionRecordingsPlaylist.tsx stays out of src/scenes/dashboard/Dashboard.tsx
🟢 src/scenes/web-analytics/tiles/WebAnalyticsTile.tsx stays out of src/scenes/dashboard/Dashboard.tsx
🟢 src/queries/validators.js stays out of src/scenes/dashboard/Dashboard.tsx
🟢 src/scenes/project-homepage/ai-first/AiFirstHomepage.tsx stays out of src/scenes/AuthenticatedShell.tsx + src/scenes/project-homepage/ProjectHomepage.tsx + src/scenes/project-homepage/today/TodayHome.tsx
🟢 src/scenes/project-homepage/today/TodayReportPage.tsx stays out of src/scenes/AuthenticatedShell.tsx + src/scenes/project-homepage/ProjectHomepage.tsx + src/scenes/project-homepage/today/TodayHome.tsx
🟢 src/queries/Query/Query.tsx stays out of src/scenes/AuthenticatedShell.tsx + src/scenes/project-homepage/ProjectHomepage.tsx + src/scenes/project-homepage/today/TodayHome.tsx
🟢 packages/quill/packages/charts/ stays out of src/scenes/AuthenticatedShell.tsx + src/scenes/project-homepage/ProjectHomepage.tsx + src/scenes/project-homepage/today/TodayHome.tsx
🟢 products/posthog_ai/frontend/components/tool/widgets/VisualizationWidget.tsx stays out of src/scenes/AuthenticatedShell.tsx + src/scenes/project-homepage/ProjectHomepage.tsx + src/scenes/project-homepage/ai-first/AiFirstHomepage.tsx
🟢 products/posthog_ai/frontend/components/tool/widgets/RecordingsWidget.tsx stays out of src/scenes/AuthenticatedShell.tsx + src/scenes/project-homepage/ProjectHomepage.tsx + src/scenes/project-homepage/ai-first/AiFirstHomepage.tsx
🟢 src/queries/Query/Query.tsx stays out of src/scenes/AuthenticatedShell.tsx + src/scenes/project-homepage/ProjectHomepage.tsx + src/scenes/project-homepage/ai-first/AiFirstHomepage.tsx
🟢 products/posthog_ai/frontend/api/primitives.ts stays out of src/scenes/AuthenticatedShell.tsx + src/scenes/project-homepage/ProjectHomepage.tsx + src/scenes/project-homepage/ai-first/AiFirstHomepage.tsx
🟢 src/scenes/notebooks/Notebook/notebookLogic.ts stays out of src/scenes/AuthenticatedShell.tsx + src/scenes/project-homepage/ProjectHomepage.tsx + src/scenes/project-homepage/ai-first/AiFirstHomepage.tsx
🟢 src/scenes/session-recordings/playlist/SessionRecordingsPlaylist.tsx stays out of src/scenes/activity/explore/EventsScene.tsx
🟢 src/scenes/web-analytics/tiles/WebAnalyticsTile.tsx stays out of src/scenes/activity/explore/EventsScene.tsx
🟢 src/queries/validators.js stays out of src/scenes/activity/explore/EventsScene.tsx
🟢 src/scenes/web-analytics/LiveMetricsDashboard/LiveWebAnalyticsMetrics.tsx stays out of src/scenes/web-analytics/WebAnalyticsScene.tsx
🟢 products/product_analytics/frontend/insights/trends/WorldMap/countryVectors.tsx stays out of src/scenes/web-analytics/WebAnalyticsScene.tsx
🟢 src/scenes/settings/SettingsMap.tsx stays out of src/scenes/session-recordings/detail/SessionRecordingDetail.tsx
🟢 @jspm/core/nodelibs/browser/fs stays out of src/scenes/session-recordings/detail/SessionRecordingDetail.tsx

Largest files eagerly shipped from src/index.tsx

Size	File
126.8 KiB	`../node_modules/.pnpm/[email protected][email protected]/node_modules/react-dom/cjs/react-dom.production.min.js`
24.6 KiB	`../node_modules/.pnpm/[email protected]/node_modules/buffer/index.js`
6.3 KiB	`../node_modules/.pnpm/[email protected]/node_modules/react/cjs/react.production.min.js`
4.7 KiB	`../node_modules/.pnpm/@[email protected]/node_modules/@jspm/core/nodelibs/browser/process.js`
4.0 KiB	`../node_modules/.pnpm/[email protected]/node_modules/scheduler/cjs/scheduler.production.min.js`
1.7 KiB	`../node_modules/.pnpm/[email protected]/node_modules/base64-js/index.js`
1.6 KiB	`src/index.tsx`
1.3 KiB	`src/lib/utils/bootTiming.ts`
1.2 KiB	`src/RootErrorBoundary.tsx`
949 B	`src/scenes/ChunkLoadErrorBoundary.tsx`

Largest files eagerly shipped from src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts

Size	File
322.5 KiB	`../node_modules/.pnpm/[email protected]_@[email protected][email protected]/node_modules/posthog-js/dist/module.mjs`
215.9 KiB	`../node_modules/.pnpm/@[email protected][email protected][email protected][email protected]/node_modules/@posthog/icons/dist/posthog-icons.es.js`
126.8 KiB	`../node_modules/.pnpm/[email protected][email protected]/node_modules/react-dom/cjs/react-dom.production.min.js`
99.8 KiB	`src/products.tsx`
86.2 KiB	`src/lib/api.ts`
68.2 KiB	`src/lib/lemon-ui/icons/icons.tsx`
41.9 KiB	`../node_modules/.pnpm/@[email protected][email protected][email protected][email protected]/node_modules/@dnd-kit/core/dist/core.esm.js`
36.4 KiB	`../node_modules/.pnpm/[email protected]_patch_hash=139b8d1f1304f9d9da452a9a1244c94ea679dbcb85687d8999563146879fb6f5_react@18.3.1/node_modules/kea/lib/index.cjs.js`
27.0 KiB	`../node_modules/.pnpm/[email protected]/node_modules/tailwind-merge/dist/bundle-mjs.mjs`
24.6 KiB	`../node_modules/.pnpm/[email protected]/node_modules/buffer/index.js`

Largest files eagerly shipped from src/scenes/AuthenticatedShell.tsx

Size	File
322.5 KiB	`../node_modules/.pnpm/[email protected]_@[email protected][email protected]/node_modules/posthog-js/dist/module.mjs`
285.9 KiB	`src/taxonomy/core-filter-definitions-by-group.json`
239.8 KiB	`../packages/quill/packages/quill/dist/index.js`
215.9 KiB	`../node_modules/.pnpm/@[email protected][email protected][email protected][email protected]/node_modules/@posthog/icons/dist/posthog-icons.es.js`
153.8 KiB	`../node_modules/.pnpm/[email protected]/node_modules/re2js/build/index.esm.js`
126.8 KiB	`../node_modules/.pnpm/[email protected][email protected]/node_modules/react-dom/cjs/react-dom.production.min.js`
99.8 KiB	`src/products.tsx`
94.5 KiB	`../node_modules/.pnpm/@[email protected]_@[email protected]/node_modules/@tiptap/core/dist/index.js`
92.5 KiB	`../node_modules/.pnpm/[email protected]/node_modules/prosemirror-view/dist/index.js`
86.2 KiB	`src/lib/api.ts`

Largest files eagerly shipped from src/scenes/dashboard/Dashboard.tsx

Size	File
322.5 KiB	`../node_modules/.pnpm/[email protected]_@[email protected][email protected]/node_modules/posthog-js/dist/module.mjs`
285.9 KiB	`src/taxonomy/core-filter-definitions-by-group.json`
239.8 KiB	`../packages/quill/packages/quill/dist/index.js`
215.9 KiB	`../node_modules/.pnpm/@[email protected][email protected][email protected][email protected]/node_modules/@posthog/icons/dist/posthog-icons.es.js`
153.8 KiB	`../node_modules/.pnpm/[email protected]/node_modules/re2js/build/index.esm.js`
144.1 KiB	`../packages/quill/packages/primitives/dist/index.js`
126.8 KiB	`../node_modules/.pnpm/[email protected][email protected]/node_modules/react-dom/cjs/react-dom.production.min.js`
99.8 KiB	`src/products.tsx`
94.5 KiB	`../node_modules/.pnpm/@[email protected]_@[email protected]/node_modules/@tiptap/core/dist/index.js`
92.5 KiB	`../node_modules/.pnpm/[email protected]/node_modules/prosemirror-view/dist/index.js`

Largest files eagerly shipped from

src/scenes/AuthenticatedShell.tsx + src/scenes/project-homepage/ProjectHomepage.tsx + src/scenes/project-homepage/today/TodayHome.tsx

Size	File
322.5 KiB	`../node_modules/.pnpm/[email protected]_@[email protected][email protected]/node_modules/posthog-js/dist/module.mjs`
285.9 KiB	`src/taxonomy/core-filter-definitions-by-group.json`
239.8 KiB	`../packages/quill/packages/quill/dist/index.js`
215.9 KiB	`../node_modules/.pnpm/@[email protected][email protected][email protected][email protected]/node_modules/@posthog/icons/dist/posthog-icons.es.js`
153.8 KiB	`../node_modules/.pnpm/[email protected]/node_modules/re2js/build/index.esm.js`
126.8 KiB	`../node_modules/.pnpm/[email protected][email protected]/node_modules/react-dom/cjs/react-dom.production.min.js`
99.8 KiB	`src/products.tsx`
94.5 KiB	`../node_modules/.pnpm/@[email protected]_@[email protected]/node_modules/@tiptap/core/dist/index.js`
92.5 KiB	`../node_modules/.pnpm/[email protected]/node_modules/prosemirror-view/dist/index.js`
86.2 KiB	`src/lib/api.ts`

Largest files eagerly shipped from

src/scenes/AuthenticatedShell.tsx + src/scenes/project-homepage/ProjectHomepage.tsx + src/scenes/project-homepage/ai-first/AiFirstHomepage.tsx

Size	File
322.5 KiB	`../node_modules/.pnpm/[email protected]_@[email protected][email protected]/node_modules/posthog-js/dist/module.mjs`
285.9 KiB	`src/taxonomy/core-filter-definitions-by-group.json`
239.8 KiB	`../packages/quill/packages/quill/dist/index.js`
215.9 KiB	`../node_modules/.pnpm/@[email protected][email protected][email protected][email protected]/node_modules/@posthog/icons/dist/posthog-icons.es.js`
153.8 KiB	`../node_modules/.pnpm/[email protected]/node_modules/re2js/build/index.esm.js`
144.1 KiB	`../packages/quill/packages/primitives/dist/index.js`
126.8 KiB	`../node_modules/.pnpm/[email protected][email protected]/node_modules/react-dom/cjs/react-dom.production.min.js`
99.8 KiB	`src/products.tsx`
94.5 KiB	`../node_modules/.pnpm/@[email protected]_@[email protected]/node_modules/@tiptap/core/dist/index.js`
92.5 KiB	`../node_modules/.pnpm/[email protected]/node_modules/prosemirror-view/dist/index.js`

Largest files eagerly shipped from src/scenes/activity/explore/EventsScene.tsx

Size	File
322.5 KiB	`../node_modules/.pnpm/[email protected]_@[email protected][email protected]/node_modules/posthog-js/dist/module.mjs`
285.9 KiB	`src/taxonomy/core-filter-definitions-by-group.json`
239.8 KiB	`../packages/quill/packages/quill/dist/index.js`
215.9 KiB	`../node_modules/.pnpm/@[email protected][email protected][email protected][email protected]/node_modules/@posthog/icons/dist/posthog-icons.es.js`
153.8 KiB	`../node_modules/.pnpm/[email protected]/node_modules/re2js/build/index.esm.js`
144.1 KiB	`../packages/quill/packages/primitives/dist/index.js`
126.8 KiB	`../node_modules/.pnpm/[email protected][email protected]/node_modules/react-dom/cjs/react-dom.production.min.js`
99.8 KiB	`src/products.tsx`
94.5 KiB	`../node_modules/.pnpm/@[email protected]_@[email protected]/node_modules/@tiptap/core/dist/index.js`
92.5 KiB	`../node_modules/.pnpm/[email protected]/node_modules/prosemirror-view/dist/index.js`

Largest files eagerly shipped from src/scenes/web-analytics/WebAnalyticsScene.tsx

Size	File
322.5 KiB	`../node_modules/.pnpm/[email protected]_@[email protected][email protected]/node_modules/posthog-js/dist/module.mjs`
285.9 KiB	`src/taxonomy/core-filter-definitions-by-group.json`
239.8 KiB	`../packages/quill/packages/quill/dist/index.js`
215.9 KiB	`../node_modules/.pnpm/@[email protected][email protected][email protected][email protected]/node_modules/@posthog/icons/dist/posthog-icons.es.js`
182.9 KiB	`src/queries/validators.js`
153.8 KiB	`../node_modules/.pnpm/[email protected]/node_modules/re2js/build/index.esm.js`
144.1 KiB	`../packages/quill/packages/primitives/dist/index.js`
126.8 KiB	`../node_modules/.pnpm/[email protected][email protected]/node_modules/react-dom/cjs/react-dom.production.min.js`
99.8 KiB	`src/products.tsx`
94.5 KiB	`../node_modules/.pnpm/@[email protected]_@[email protected]/node_modules/@tiptap/core/dist/index.js`

Largest files eagerly shipped from src/scenes/session-recordings/detail/SessionRecordingDetail.tsx

Size	File
322.5 KiB	`../node_modules/.pnpm/[email protected]_@[email protected][email protected]/node_modules/posthog-js/dist/module.mjs`
316.1 KiB	`../node_modules/.pnpm/[email protected]_@[email protected][email protected]/node_modules/posthog-js/dist/rrweb.js`
285.9 KiB	`src/taxonomy/core-filter-definitions-by-group.json`
239.8 KiB	`../packages/quill/packages/quill/dist/index.js`
215.9 KiB	`../node_modules/.pnpm/@[email protected][email protected][email protected][email protected]/node_modules/@posthog/icons/dist/posthog-icons.es.js`
153.8 KiB	`../node_modules/.pnpm/[email protected]/node_modules/re2js/build/index.esm.js`
126.8 KiB	`../node_modules/.pnpm/[email protected][email protected]/node_modules/react-dom/cjs/react-dom.production.min.js`
99.8 KiB	`src/products.tsx`
94.5 KiB	`../node_modules/.pnpm/@[email protected]_@[email protected]/node_modules/@tiptap/core/dist/index.js`
92.5 KiB	`../node_modules/.pnpm/[email protected]/node_modules/prosemirror-view/dist/index.js`

_{Posted automatically by check-eager-graph · sizes are eager output bytes (shipped, post-tree-shake) from the esbuild metafile · part of #32479}

✅ Toolbar bundle — eager 2.29 MiB within budget

What the toolbar ships to customer pages, measured from the esbuild output (minified, post-tree-shake). The eager set is the entry plus everything statically imported from it — fetched before any feature runs; deferred chunks load lazily. The eager guardrail is 5.72 MiB. Each output file must also stay below 10 MB, where CloudFront stops compressing it. The module boundary is enforced separately by check-toolbar-graph.

Metric	Size	Δ vs base	Budget
Eager (shipped) entry + static imports	2.29 MiB · 18 files	no change	`████░░░░░░` 40.0% of 5.72 MiB
Deferred (lazy)	2.11 MiB · 40 files	no change	n/a — loads on demand
Loader `dist/toolbar.js`	1.2 KiB	no change	`█░░░░░░░░░` 6.0% of 19.5 KiB

Largest eagerly-shipped chunks

Size	File
902.2 KiB	`dist/toolbar/toolbar-app-CRD3W4A7.css`
692.2 KiB	`dist/toolbar/chunk-chunk-KZJS3INZ.js`
260.7 KiB	`dist/toolbar/chunk-chunk-L6XVLVLY.js`
131.8 KiB	`dist/toolbar/chunk-chunk-FDH2IBXT.js`
130.4 KiB	`dist/toolbar/chunk-chunk-LD5GP6L7.js`
74.8 KiB	`dist/toolbar/toolbar-app-TXKYX4J5.js`
69.0 KiB	`dist/toolbar/chunk-chunk-TSAL54PB.js`
35.6 KiB	`dist/toolbar/chunk-chunk-WFB7UOXI.js`
21.7 KiB	`dist/toolbar/chunk-chunk-CRQXLGRI.js`
6.8 KiB	`dist/toolbar/chunk-chunk-DV7IWQNF.js`

_{Posted automatically by check-toolbar-size · sizes are toolbar output bytes (shipped, post-tree-shake) from the esbuild metafile}

✅ Dist folder size — 🔺 +1.0 KiB (+0.0%)

Total size of the built frontend/dist folder (all assets), compared against the base branch.

Total: 964.85 MiB · 🔺 +1.0 KiB (+0.0%)

✅ Playwright — all passed

All tests passed.

View test results →

trunk-io · 2026-10-25T17:44:30Z

Failed Test	Failure Summary	Logs
`Scenes-App/Notebooks/Nodes/Customer Journey AllStepsCompleted smoke-test`	The test timed out while waiting for an element with the class '.react-flow__node' to become visible.	Logs ↗︎
`Scenes-App/Experiments ExperimentWithHealthFindings play-test`	The Storybook test could not find the text “Why?” because the experiment page remained stuck on a loading spinner.	Logs ↗︎

_{View Full Report ↗︎ ⋅ Docs}

parameterai · 2026-10-25T18:31:09Z

Risk: No findings

This PR is a pure code move: it extracts the window, path, and breakdown HogQL query builders (plus formatShare/changeVsPrevious) from pagePerformanceLogic.ts into a new searchAndAiQueries.ts under products/web_analytics/frontend/searchAndAi/, updating imports in the logic, breakdown modal, metric cell, and tests. I verified the moved code is byte-identical to the removed code and every user-controlled value (page, candidates, path-cleaning regex/alias, GSC table name) is still escaped via escapeHogQLString / escapeDottedHogQLIdentifier, so the HogQL string-building behavior and its injection guards are unchanged. No security-relevant behavior change; the only thing worth a second look is purely stylistic (the new file importing DateFilterState from scenes/web-analytics/webAnalyticsLogic crosses the products/scenes tree boundary).

_{Sentinel reviewed 4c5e499 · Review settings}

jordanm-posthog · 2026-10-25T18:48:47Z

@PostHog review

posthog · 2026-10-25T18:48:53Z

@jordanm-posthog PostHog Review is reviewing this pull request.

posthog

PostHog Review · Standard · reviewed 4c5e499: no findings.

stamphog

Approved.

Contained refactor with unchanged query behavior and escaping; no open substantive review concerns. The current head has an independent review, and the author belongs to the owning team with strong familiarity.

Author wrote 99% of the modified lines and has 53 merged PRs in these paths (familiarity STRONG).
PostHog Review (Standard) reviewed the current head: no findings.
posthog[bot] reviewed the current head.

Gate mechanics and policy version

Gate		Result
prerequisites	✓	all clear
deny-list	✓	no deny categories matched
size	✓	389L, 4F substantive, 398L/5F incl. docs/generated/snapshots — within ceiling
tier	✓	T1-agent / T1d-complex (398L, 5F, two-areas, refactor)
stamphog 2.6.1		`.stamphog/policy.yml` @ `4c5e499` · reviewed head `4c5e499`

trunk-io · 2026-10-26T00:37:44Z

This pull request was merged into master as part of stacked PR 123199.

deployment-status-posthog · 2026-10-26T01:01:13Z

Deploy status

Environment	Status	Deployed At	Workflow
dev	✅ Deployed	2026-10-26 01:01 UTC	Run
prod-us	✅ Deployed	2026-10-26 01:15 UTC	Run
prod-eu	✅ Deployed	2026-10-26 01:15 UTC	Run

refactor(web-analytics): extract search and ai query builders

4c5e499

pr-assigner-resolver-posthog Bot assigned jordanm-posthog Oct 25, 2026

jordanm-posthog added this pull request to stack #123200 October 25, 2026 17:25

jordanm-posthog changed the title ~~jordanm posthog/page reports 2a extract queries~~ refactor(web-analytics): extract search and ai query builders Oct 25, 2026

jordanm-posthog mentioned this pull request Oct 25, 2026

feat(web-analytics): add page directory logic #123197

Merged

jordanm-posthog marked this pull request as ready for review October 25, 2026 18:31

pr-assigner-resolver-posthog Bot requested a review from a team October 25, 2026 18:31

posthog Bot reviewed Oct 25, 2026

View reviewed changes

stamphog Bot approved these changes Oct 25, 2026

View reviewed changes

lricoy approved these changes Oct 25, 2026

View reviewed changes

trunk-io Bot merged commit 724ae13 into master Oct 26, 2026
330 of 331 checks passed

trunk-io Bot deleted the jordanm-posthog/page-reports-2a-extract-queries branch October 26, 2026 00:37

Navigation Menu

Repository navigation

refactor(web-analytics): extract search and ai query builders - #123196

refactor(web-analytics): extract search and ai query builders#123196
trunk-io[bot] merged 1 commit into
masterfrom
jordanm-posthog/page-reports-2a-extract-queries

jordanm-posthog commented Oct 25, 2026 •

edited

Loading

Uh oh!

trunk-io Bot commented Oct 25, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 25, 2026 •

edited

Loading

Uh oh!

trunk-io Bot commented Oct 25, 2026 •

edited

Loading

Uh oh!

parameterai Bot commented Oct 25, 2026 •

edited

Loading

Uh oh!

jordanm-posthog commented Oct 25, 2026

Uh oh!

posthog Bot commented Oct 25, 2026

Uh oh!

posthog Bot left a comment

Uh oh!

stamphog Bot left a comment

Uh oh!

Uh oh!

trunk-io Bot commented Oct 26, 2026

Uh oh!

deployment-status-posthog Bot commented Oct 26, 2026 •

edited

Loading

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

jordanm-posthog commented Oct 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Changes

How did you test this code?

Release status

Docs update

🤖 Agent context

Uh oh!

trunk-io Bot commented Oct 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🤖 CI report

Uh oh!

trunk-io Bot commented Oct 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

parameterai Bot commented Oct 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jordanm-posthog commented Oct 25, 2026

Uh oh!

posthog Bot commented Oct 25, 2026

Uh oh!

posthog Bot left a comment

Choose a reason for hiding this comment

Uh oh!

stamphog Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

trunk-io Bot commented Oct 26, 2026

Uh oh!

deployment-status-posthog Bot commented Oct 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploy status

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jordanm-posthog commented Oct 25, 2026 •

edited

Loading

trunk-io Bot commented Oct 25, 2026 •

edited

Loading

github-actions Bot commented Oct 25, 2026 •

edited

Loading

trunk-io Bot commented Oct 25, 2026 •

edited

Loading

parameterai Bot commented Oct 25, 2026 •

edited

Loading

deployment-status-posthog Bot commented Oct 26, 2026 •

edited

Loading