Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/workflows/cla.yml
Original file line number Diff line number Diff line change
Expand Up @@ -71,3 +71,13 @@ jobs:
remote-organization-name: ${{ github.repository_owner }}
remote-repository-name: cla-signatures
signed-commit-message: $contributorName has signed the CLA in $owner/$repo#$pullRequestNo
# The bot's request to sign. A ruleset never runs this workflow on a comment, so the
# request says when a signature counts rather than offering `recheck`, which nothing hears.
suggest-recheck: false
custom-notsigned-prcomment: >-
<br/>Thank you for your submission, we really appreciate it. Like many open-source
projects, we ask that $you sign our [Contributor License
Agreement](https://github.com/Pipelex/.github/blob/main/CLA.md) before we can accept
your contribution. You can sign the CLA by posting a pull request comment in the format
below. The check reads signatures when it runs, so once you have commented, push a new
commit to this pull request or ask a maintainer to re-run the CLAAssistant check.<br/>
2 changes: 1 addition & 1 deletion docs/cla.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Every public Pipelex repository that asks contributors to sign a contributor lic

GitHub runs the workflow as it is on this repository's `main`, in the context of the pull request's repository: the secrets it reads are the ones granted to that repository, the allowlist is the organization variable `CLA_ALLOWLIST`, and the document it asks a contributor to sign is [`CLA.md`](../CLA.md) at the root of this repository, one agreement for every Pipelex project. A repository may still carry its own copy for its readers, but the bot links this one. Signatures are recorded in `Pipelex/cla-signatures`, so a contributor who signs once is signed for every repository. A change to the workflow therefore reaches every repository when `dev` is promoted to `main` here.

**A signature takes effect at the next run.** A workflow required by a ruleset runs only on pull request events, never on a comment, so after a contributor comments the signing sentence, the check passes once the contributor pushes again or a maintainer re-runs the failed `CLAAssistant` job; that run reads the comment and records the signature.
**A signature takes effect at the next run.** A workflow required by a ruleset runs only on pull request events, never on a comment, so after a contributor comments the signing sentence, the check passes once the contributor pushes again or a maintainer re-runs the failed `CLAAssistant` job; that run reads the comment and records the signature. The bot's request to sign says so, and it does not offer the action's `recheck` comment (`suggest-recheck: false`), which nothing would hear.

## The patched action

Expand Down