chore: group project includes after system headers - #11
Merged
Conversation
The automated include insertion for menu.h / input.h dropped them right after the <system> header and before the project headers in five files. Move them to the end of the project-include group so the ordering is consistent (system headers, then project headers). Include-only change, no behaviour difference.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
When
menu.h/input.hwere added by an automated insertion, they landedright after the
<system>header and before the project headers in five files(move, manage_mobs, perso, quest, npc). Banana-clean and compiling, but the
include order was inconsistent.
What
Move those headers to the end of the project-include group, so every file reads
system headers first, then project headers. Include-only change.
Verification
make re: warning-free.make tests_run: 20/20.