Repository navigation
fix: FO4 acoustic/sound markers stay hidden after Markers hide -> show - #245
Merged
Perchik71 merged 1 commit intoOct 15, 2026
Merged
Conversation
The render window "Show Markers" handler culls the cell's "SoundMarker Node" (where acoustic space and sound markers live) when markers are turned off, via a function that has no other caller; the show branch never un-culls it, so the node stays hidden until the cell is reloaded. The new patch calls SetSoundMarkerNodeCulled(manager, false) at the end of the show branch. The handler and the function are resolved with address IDs for CK 1.10.162.0, 1.10.982.3, 1.11.137.0 and 1.11.240.0, and the hook site is checked before patching. Closes Perchik71#96
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The render window "Show Markers" handler culls the cell's "SoundMarker Node" (where acoustic space and sound markers live) when markers are turned off, via a function that has no other caller; the show branch never un-culls it, so the node stays hidden until the cell is reloaded.
The new patch calls SetSoundMarkerNodeCulled(manager, false) at the end of the show branch. The handler and the function are resolved with address IDs for CK 1.10.162.0, 1.10.982.3, 1.11.137.0 and 1.11.240.0, and the hook site is checked before patching.
Closes #96