Repository navigation
Fallout4: fix FakeMoveLight crash on CK 1.10.162.0 when dragging a primitive - #244
Merged
Merged
Conversation
…imitive The 11 bytes written before the SetPosition hook call load the reference from r12, the position from [rbp-49h] and the render window edit module from r14. That is the register layout of 1.10.982.3, 1.11.137.0 and 1.11.240.0 only. In 1.10.162.0 the reference is in rbx, the edit module in rsi and the source position at [rbp-61h], so the hook got a non-reference object and the CK crashed in BSSpinLock::Lock while dragging a primitive. Write the 1.10.162.0 register layout for that runtime.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 11 bytes written before the SetPosition hook call load the reference from r12, the position from [rbp-49h] and the render window edit module from r14. That is the register layout of 1.10.982.3, 1.11.137.0 and 1.11.240.0 only. In 1.10.162.0 the reference is in rbx, the edit module in rsi and the source position at [rbp-61h], so the hook got a non-reference object and the CK crashed in BSSpinLock::Lock while dragging a primitive.
Write the 1.10.162.0 register layout for that runtime.