Repository navigation
Fallout4: fix Layers window count growing when a primitive is moved - #243
Merged
Merged
Conversation
TESObjectREFR::Set3D replaces the 3D of a reference that already has one and still sends the "3D loaded" event. The Layers window counts every such event as one more reference in the layer and never gets the matching "unloaded" one, so the "#" column grows on every primitive move. Skip the notify on the replace path of Set3D (1.10.162.0, 1.10.982.3, 1.11.137.0, 1.11.240.0; address ID 531824, bytes verified before patching).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TESObjectREFR::Set3D replaces the 3D of a reference that already has one and still sends the "3D loaded" event. The Layers window counts every such event as one more reference in the layer and never gets the matching "unloaded" one, so the "#" column grows on every primitive move.
Skip the notify on the replace path of Set3D (1.10.162.0, 1.10.982.3, 1.11.137.0, 1.11.240.0; address ID 531824, bytes verified before patching).