Fix floppy disk in drive not restoring visually in-world on reload - #64
Merged
RobertCochran merged 1 commit intoAug 22, 2026
Merged
Conversation
RobertCochran
commented
Aug 21, 2026
Comment on lines
-146
to
-156
| override def loadForClient(nbt: CompoundTag, provider: HolderLookup.Provider): Unit = { | ||
| super.loadForClient(nbt, provider) | ||
| if (nbt.contains(DiskTag)) { | ||
| setItem(0, ItemStack.parseOptional(provider, nbt.getCompound(DiskTag))) | ||
| } | ||
| } | ||
|
|
||
| override def saveForClient(nbt: CompoundTag, provider: HolderLookup.Provider): Unit = { | ||
| super.saveForClient(nbt, provider) | ||
| if (!items(0).isEmpty) nbt.setNewCompoundTag(DiskTag, _ => items(0).save(provider)) | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
It seems like these specialization methods were causing conflicts on world save/load? Removing them and just directly propagating to super.{load,save}ForClient() seems to have fixed the visual issue with no notice of any breakage based on my handful of minutes testing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempts to fix an issue where the floppy disk does not visually restore in-world on disk drive reload (save+quit, server relog, etc).