Fix usages of ItemStack.save with setNewCompoundTag - #65
Merged
Conversation
The correct usage should either be .put(stack.save(...)) or .setNewCompoundTag(stack.save(..., _)), otherwise we just discard the stack.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setNewCompoundTag(key, tag => ...)expects the lambda to mutate the tag. However, we were calling this likesetNewCompoundTag(key, _ => stack.save(registries)), which means we never actually save the stack. The correct usage should either be.put(stack.save(...))(which is what we use here) or.setNewCompoundTag(stack.save(..., _)).This is the cause of #64 too, but in that case deleting the overrides is sufficient.