Filed issue #956: label preflight skips game run. - #957
Open
opencode-agent[bot] wants to merge 1 commit into
Open
Filed issue #956: label preflight skips game run.#957opencode-agent[bot] wants to merge 1 commit into
opencode-agent[bot] wants to merge 1 commit into
Conversation
Contributor
|
User opencode-agent[bot] does not have write permissions |
Contributor
kcov coverageLine coverage ran for this PR and uploaded a non-blocking report artifact named |
Contributor
|
Found 1 test failure on Blacksmith runners: Failure
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Filed as issue #956 — #956
Root cause: The visual-test workflow never actually runs the game. The
Ensure visual-test label existsstep in.github/workflows/visual-test.yml:55-68callsgh label list --json name --jq '.[].name', which paginates with a default of 30 entries. The repo now has 41 labels, andrun-visual-test(position 41) falls off page 1, so the script attemptsgh label create "run-visual-test" .... That fails withlabel with name "run-visual-test" already exists; use --force to update its color and description(exit 1), which fails the step and skips everything after it — includingSetup Lavapipe VulkanandRun menu screenshot capture. Onlyweston.logsurvives in the workspace; nobuild-output.log, noscreenshot.png. The Zig/Vulkan/screenshot.zigcode path is never exercised, so the PPM hypothesis invisual-test-diagnose.mdis stale.Triggered by scheduled workflow
opencode session | github run