Skip to content

Filed issue #958: label preflight pagination skips screenshot. - #959

Open
opencode-agent[bot] wants to merge 1 commit into
devfrom
opencode/schedule-ace015-20260729073440
Open

Filed issue #958: label preflight pagination skips screenshot.#959
opencode-agent[bot] wants to merge 1 commit into
devfrom
opencode/schedule-ace015-20260729073440

Conversation

@opencode-agent

Copy link
Copy Markdown
Contributor

Filed issue #958: #958

Root cause: build-output.log does not exist in the workspace, so the screenshot step never ran. The Ensure visual-test label exists step at .github/workflows/visual-test.yml:55-68 calls gh label list --json name --jq '.[].name' which paginates at 30 entries. The repo has 41 labels; both visual-test and run-visual-test are on page 2 (https://github.com/OpenStaticFish/ZigCraft/labels?page=2). The if ! ... | grep -q guard therefore fires gh label create, which exits 1 because the labels already exist. Without if: always() on Run menu screenshot capture, every later step is skipped.

The PPM hypothesis in .github/prompts/visual-test-diagnose.md is stale — the workflow already uses screenshot.png and the game was never invoked. Same regression as #956 (run #30338232720); fix in PR #957 is still unmerged. Suggested patch uses --paginate and moves the existence guard inline so the step no longer fails on existing labels.

Triggered by scheduled workflow

New%20session%20-%202026-07-29T07%3A34%3A39.784Z
opencode session  |  github run

@github-actions github-actions Bot added documentation Improvements or additions to documentation build labels Jul 29, 2026
@github-actions

Copy link
Copy Markdown
Contributor

User opencode-agent[bot] does not have write permissions

github run

@github-actions

Copy link
Copy Markdown
Contributor

kcov coverage

Line coverage ran for this PR and uploaded a non-blocking report artifact named kcov-report. Codecov upload is configured as non-blocking while the project captures a stable baseline.

@blacksmith-sh

blacksmith-sh Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Found 1 test failure on Blacksmith runners:

Failure

Test View Logs
(TestExpectedEqual)/(TestExpectedEqual) View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants