Filed issue #958: label preflight pagination skips screenshot. - #959
Open
opencode-agent[bot] wants to merge 1 commit into
Open
Filed issue #958: label preflight pagination skips screenshot.#959opencode-agent[bot] wants to merge 1 commit into
opencode-agent[bot] wants to merge 1 commit into
Conversation
Contributor
|
User opencode-agent[bot] does not have write permissions |
Contributor
kcov coverageLine coverage ran for this PR and uploaded a non-blocking report artifact named |
Contributor
|
Found 1 test failure on Blacksmith runners: Failure
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light.png)
Filed issue #958: #958
Root cause:
build-output.logdoes not exist in the workspace, so the screenshot step never ran. TheEnsure visual-test label existsstep at.github/workflows/visual-test.yml:55-68callsgh label list --json name --jq '.[].name'which paginates at 30 entries. The repo has 41 labels; bothvisual-testandrun-visual-testare on page 2 (https://github.com/OpenStaticFish/ZigCraft/labels?page=2). Theif ! ... | grep -qguard therefore firesgh label create, which exits 1 because the labels already exist. Withoutif: always()onRun menu screenshot capture, every later step is skipped.The PPM hypothesis in
.github/prompts/visual-test-diagnose.mdis stale — the workflow already usesscreenshot.pngand the game was never invoked. Same regression as #956 (run #30338232720); fix in PR #957 is still unmerged. Suggested patch uses--paginateand moves the existence guard inline so the step no longer fails on existing labels.Triggered by scheduled workflow
opencode session | github run