Label preflight paginates, skips screenshot run. - #953
Open
opencode-agent[bot] wants to merge 1 commit into
Open
Label preflight paginates, skips screenshot run.#953opencode-agent[bot] wants to merge 1 commit into
opencode-agent[bot] wants to merge 1 commit into
Conversation
Contributor
|
User opencode-agent[bot] does not have write permissions |
Contributor
kcov coverageLine coverage ran for this PR and uploaded a non-blocking report artifact named |
Contributor
|
Found 1 test failure on Blacksmith runners: Failure
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue filed: #952
Summary of the diagnosis:
build-output.logwas missing in the workspace because the workflow'sEnsure visual-test label existsstep failed before the screenshot step could run (job summary: that step isX(failed) and every subsequent step is-(skipped)).screenshot.ppmhypothesis doesn't match the actual workflow command (-Dscreenshot-path=screenshot.pngatvisual-test.yml:81); I verified locally that the real PPM path would error indetectScreenshotFormat()atscreenshot.zig:262-267, but that path is never reached in this run.gh label list --json name --jq '.[].name'paginates with a 30-item default; oncerun-visual-testfalls off page 1, the workflow re-creates it andgh label createerrors withlabel with name "run-visual-test" already exists; use --force to update its color and descriptionatvisual-test.yml:55-68.--paginateand|| trueto the label-preflight script, and update the stalevisual-test-diagnose.mdprompt so future agents don't fabricate PPM-rejection output.Triggered by scheduled workflow
opencode session | github run