Label preflight pagination skips game run. - #965
Open
opencode-agent[bot] wants to merge 1 commit into
Open
Conversation
Contributor
|
User opencode-agent[bot] does not have write permissions |
Contributor
kcov coverageLine coverage ran for this PR and uploaded a non-blocking report artifact named |
Contributor
|
Found 1 test failure on Blacksmith runners: Failure
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light.png)
Filed: #964
Diagnosis:
build-output.logwas absent because the workflow short-circuited at.github/workflows/visual-test.yml:55-68(Ensure visual-test label exists).gh label list --json namedefaults to a 30-item page, but the repo has 41 labels, sorun-visual-test(alphabetical position 41) falls off page 1. The script tries to recreate it,gh label createexits 1 withlabel with name "run-visual-test" already exists, and the step's lack ofcontinue-on-errorskipsSetup Lavapipe VulkanandRun menu screenshot capture— leaving onlyweston.log.The prompt's
.ppmhypothesis is stale:visual-test.yml:81already passes-Dscreenshot-path=screenshot.png, andscreenshot.zig:262-268(detectScreenshotFormat) accepts that extension — so the Zig/Vulkan code path is never reached.This is the same root cause as #916, #931, #935, #942, #944, #945, #946, #947, #949, #950, #952, #954, #956, #958, #960; PR #953 is still the proposed fix.
Triggered by scheduled workflow
opencode session | github run