Skip to content

[Backport release-26.05] vscode: 1.142.0 -> 1.144.0 - #580502

Merged
JohnRTitor merged 1 commit into
NixOS:release-26.05from
Max-42:backport-vscode-1.143.1
Nov 2, 2026
Merged

JohnRTitor merged 1 commit into
NixOS:release-26.05from
Max-42:backport-vscode-1.143.1

Conversation

@Max-42

@Max-42 Max-42 commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

vscode: backport update to 1.143.1 to release-26.05

Backport of #579744.

Updates VS Code from 1.119.0 to 1.143.1 on release-26.05.

Upstream changelog: https://code.visualstudio.com/updates/v1_143

(cherry picked from commit 18f3221)

Things done

@nixpkgs-commit-check nixpkgs-commit-check Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This report is automatically generated by the PR / Check / cherry-pick CI workflow.

Some of the commits in this PR require the author's and reviewer's attention.

If you need to merge this PR despite the warnings, please dismiss this review shortly before merging.

Important

ed7283f is not a cherry-pick, because: Skips intermediate versions and updates stable directly to 1.144.0.. Please review this commit manually.

Hint: The full diffs are also available in the runner logs with slightly better highlighting.

@nixpkgs-ci nixpkgs-ci Bot added 8.has: package (update) This PR updates a package to a newer version 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 6.topic: vscode A free and versatile code editor that supports almost every major programming language. 4.workflow: backport This targets a stable branch labels Oct 29, 2026
@Max-42

Max-42 commented Oct 29, 2026

Copy link
Copy Markdown
Contributor Author

In reply to #580502 (review):

The cherry-pick required resolving a conflict because release-26.05 has VS Code 1.119.0 instead of the upstream commit's base version 1.142.0.

I kept the stable branch's existing x86_64-darwin hash and used the updated hashes, version and rev from the upstream commit. The patch only contains changes to pkgs/applications/editors/vscode/vscode.nix.

@Max-42
Max-42 marked this pull request as ready for review October 29, 2026 13:04
@Max-42 Max-42 changed the title vscode: 1.142.0 -> 1.143.1 vscode: 1.142.0 -> 1.144.0 Oct 29, 2026
@Max-42

Max-42 commented Oct 29, 2026

Copy link
Copy Markdown
Contributor Author

I've added the 1.144.0 update as a second commit, following upstream PR #580540.

@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Oct 31, 2026
@Max-42
Max-42 force-pushed the backport-vscode-1.143.1 branch from cca8c9f to 388fca7 Compare November 2, 2026 13:11
Not-cherry-picked-because: Skips intermediate versions and updates stable directly to 1.144.0.
@Max-42
Max-42 force-pushed the backport-vscode-1.143.1 branch from 388fca7 to ed7283f Compare November 2, 2026 13:16
@Max-42
Max-42 requested a review from JohnRTitor November 2, 2026 13:25
@JohnRTitor JohnRTitor changed the title vscode: 1.142.0 -> 1.144.0 [Backport release-26.05] vscode: 1.142.0 -> 1.144.0 Nov 2, 2026
@JohnRTitor
JohnRTitor added this pull request to the merge queue Nov 2, 2026
Merged via the queue into NixOS:release-26.05 with commit 41dcd62 Nov 2, 2026
33 checks passed
@Max-42
Max-42 deleted the backport-vscode-1.143.1 branch November 3, 2026 12:11
@dasJ

dasJ commented Nov 4, 2026

Copy link
Copy Markdown
Member

After updating, I get:

Running phase: unpackPhase
unpacking source archive /nix/store/nddxnzrjcnlyx5d414506qnq0da0xqb9-VSCode_1.144.0_linux-x64.tar.gz
source root is VSCode-linux-x64
setting SOURCE_DATE_EPOCH to timestamp 1793133762 of file "VSCode-linux-x64/bin/copilot-shim/copilot"
Running phase: patchPhase
rm: cannot remove 'resources/app/node_modules/@vscode/ripgrep/bin/rg': No such file or directory

@Kiskae

Kiskae commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Yup, looks like this backport is missing part of this PR: 08a2d5f

@mweinelt

mweinelt commented Nov 8, 2026

Copy link
Copy Markdown
Member

@JohnRTitor Can you clarify how you tested this PR?

@Max-42

Max-42 commented Nov 8, 2026

Copy link
Copy Markdown
Contributor Author

I'm still relatively new to this, I got some branches mixed up.

I want to apologize for the confusion. I've tried to correct this in #585147.

Sorry this was my misstake!

@dotlambda dotlambda mentioned this pull request Nov 9, 2026
3 of 13 tasks
@JohnRTitor

Copy link
Copy Markdown
Member

@JohnRTitor Can you clarify how you tested this PR?

I looked at the hashes, and they matched and so I thought they were fine. I apologize.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4.workflow: backport This targets a stable branch 6.topic: vscode A free and versatile code editor that supports almost every major programming language. 8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants