Repository navigation
[Backport release-26.05] vscode: 1.142.0 -> 1.144.0 - #580502
Conversation
There was a problem hiding this comment.
This report is automatically generated by the PR / Check / cherry-pick CI workflow.
Some of the commits in this PR require the author's and reviewer's attention.
If you need to merge this PR despite the warnings, please dismiss this review shortly before merging.
Important
ed7283f is not a cherry-pick, because: Skips intermediate versions and updates stable directly to 1.144.0.. Please review this commit manually.
Hint: The full diffs are also available in the runner logs with slightly better highlighting.
|
In reply to #580502 (review): The cherry-pick required resolving a conflict because release-26.05 has VS Code 1.119.0 instead of the upstream commit's base version 1.142.0. I kept the stable branch's existing x86_64-darwin hash and used the updated hashes, version and rev from the upstream commit. The patch only contains changes to pkgs/applications/editors/vscode/vscode.nix. |
|
I've added the 1.144.0 update as a second commit, following upstream PR #580540. |
cca8c9f to
388fca7
Compare
Not-cherry-picked-because: Skips intermediate versions and updates stable directly to 1.144.0.
388fca7 to
ed7283f
Compare
|
After updating, I get: |
|
Yup, looks like this backport is missing part of this PR: 08a2d5f |
|
@JohnRTitor Can you clarify how you tested this PR? |
|
I'm still relatively new to this, I got some branches mixed up. I want to apologize for the confusion. I've tried to correct this in #585147. Sorry this was my misstake! |
I looked at the hashes, and they matched and so I thought they were fine. I apologize. |
vscode: backport update to 1.143.1 to release-26.05
Backport of #579744.
Updates VS Code from 1.119.0 to 1.143.1 on release-26.05.
Upstream changelog: https://code.visualstudio.com/updates/v1_143
(cherry picked from commit 18f3221)
Things done
nixpkgs-reviewon this PR. See nixpkgs-review usage.passthru.tests.