Skip to content

Revert "vscode: 1.119.0 -> 1.144.0" - #585279

Merged
dotlambda merged 1 commit into
NixOS:release-26.05from
dotlambda:vscode
Nov 9, 2026
Merged

Revert "vscode: 1.119.0 -> 1.144.0"#585279
dotlambda merged 1 commit into
NixOS:release-26.05from
dotlambda:vscode

Conversation

@dotlambda

@dotlambda dotlambda commented Nov 9, 2026

Copy link
Copy Markdown
Member

This reverts #580502 because it broke the build of vscode.

Things done

@dotlambda
Revert "vscode: 1.119.0 -> 1.144.0"
543f9a3 
This reverts commit ed7283f because it
broke the build of vscode.
nixpkgs-commit-check[bot]
nixpkgs-commit-check Bot previously requested changes Nov 9, 2026
View reviewed changes

@nixpkgs-commit-check nixpkgs-commit-check Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This report is automatically generated by the PR / Check / cherry-pick CI workflow.

Some of the commits in this PR require the author's and reviewer's attention.

Please follow the backporting guidelines and cherry-pick with the -x flag.
This requires changes to the unstable master and staging branches first, before backporting them.

Occasionally, commits are not cherry-picked at all, for example when updating minor versions of packages which have already advanced to the next major on unstable.
These commits can optionally be marked with a Not-cherry-picked-because: <reason> footer.

If you need to merge this PR despite the warnings, please dismiss this review shortly before merging.

Warning

Couldn't locate the cherry-picked commit's hash in the commit message of 543f9a3.

Hint: The full diffs are also available in the runner logs with slightly better highlighting.

@dotlambda
dotlambda dismissed nixpkgs-commit-check[bot]’s stale review November 9, 2026 06:18

It's a revert of a commit already in release-26.05.

@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 6.topic: vscode A free and versatile code editor that supports almost every major programming language. 4.workflow: backport This targets a stable branch labels Nov 9, 2026
@dotlambda

dotlambda commented Nov 9, 2026

Copy link
Copy Markdown
Member Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 585279
Commit: 543f9a3ef46a92ab0363da87e61eeceec99b600d

x86_64-linux

✅ 3 packages built:
  • vscode
  • vscode-fhs
  • vscode-with-extensions

@dotlambda
dotlambda added this pull request to the merge queue Nov 9, 2026
Merged via the queue into NixOS:release-26.05 with commit 0012dda Nov 9, 2026
34 checks passed
@dotlambda
dotlambda deleted the vscode branch November 9, 2026 06:32
@Max-42 Max-42 mentioned this pull request Nov 9, 2026
Closed
2 of 13 tasks
@mikegerber mikegerber mentioned this pull request Nov 11, 2026
Open
4 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nixpkgs-commit-check nixpkgs-commit-check[bot] nixpkgs-commit-check[bot] left review comments
@bobby285271 bobby285271 Awaiting requested review from bobby285271
@eadwu eadwu Awaiting requested review from eadwu
@JeffLabonte JeffLabonte Awaiting requested review from JeffLabonte
@JohnRTitor JohnRTitor Awaiting requested review from JohnRTitor
@oenu oenu Awaiting requested review from oenu
@yuannan yuannan Awaiting requested review from yuannan

Assignees

No one assigned

Labels

4.workflow: backport This targets a stable branch 6.topic: vscode A free and versatile code editor that supports almost every major programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@dotlambda