Skip to content

fix(music): serve native uncached note requests - #44

Merged
NickMesser merged 21 commits into
rust-rewritefrom
fix/bevy-music-request
Oct 23, 2026
Merged

NickMesser merged 21 commits into
rust-rewritefrom
fix/bevy-music-request

Conversation

@NickMesser

Copy link
Copy Markdown
Owner

Native 1.2 sends CS123(false,false) for an uncached score, but the packed-u16 switch ignored it. Decode isTooltip/showBuffOnly independently and echo the tooltip flag in note replies. Existing buff-only, missing-song and 32-bit lookup/reply behavior is retained; unresolved high-bit ID alias/cache limits are documented.

Validation: reproduced the missing SC1e0 response before the fix; all 9 focused music tests, scoped Clippy and the full lane check passed (3,596 Rust tests plus 7 coverage tests). An isolated live headless lane verified 7 raw request/reply/buff cases. Lane resources were removed. Composition, audio playback and End are outside this verification.

stsiakal and others added 21 commits October 22, 2026 06:51
Resolve SummonPos casts to the client-chosen spot, validate it against slaves.spawn_valid_area_range / skill range, water/ground and collision, and fall back to the C# in-front spawn with SlaveSpawnErrorInvalidArea when invalid. Implement CSChangeSlaveEquipmentPacket for equip/unequip/re-slot using a persistent EquipmentSlave container keyed by the slave DB id, ItemDetailType.SlaveEquipment items, SCUnitEquipmentsChanged / SCSlaveEquipmentChanged and gear/pool refreshes.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Load slave_equip_slots, item_slave_equipments and the hull/slot allow packs. Validate CSChangeSlaveEquipment against the hull and target slot before moving items, and refuse with ItemNotForPet without a move. Spawn the part's child slave or doodad at the slot attach points on equip, remove it on unequip, and respawn them from the persistent container on summon; static bindings now only cover points without an equipment slot. Seed the starter pack only into declared slots. Add client-extracted attach points for models 511, 1482 and 1546.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
A cannon (kind 8) mounted on a ship has one gunner seat (attach point 1).
CSBindSlave refuses non-crew (SLAVE_CANNOT_BIND), a second gunner
(SLAVE_ALREADY_HAS_MASTER) and riders of another slave (SLAVE_UNBIND_FIRST).
Only the gunner casts the cannon's mount skills. The gunner is unbound when
the ship is recalled, destroyed or the cannon unequipped, and on death; the
seat sits at GUNNER_SEAT_OFFSET behind the barrel and follows the ship.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Character creation wrote only the characters row; containers and items waited for the next
world or departure save, so a stop in between kept the character without its starter gear.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Initialize slave equipment when its persistent container is created, migrate exact legal static defaults, and preserve bindings without item equivalents. Require matching cannon driver seats and attachments, and detach child gunners before carrier death removes their cannons. Snapshot object state before child and world lookups.

Add deterministic, real compact-data, and private MySQL persistence regressions. Keep the MySQL fixture reusable across owned lanes.

Co-Authored-By: Codex <[email protected]>
Keep inventory registration, atomic character persistence, and rejected-creation cleanup under the save transaction lock. Record canceled deletions at item allocation so rollback restores IDs released by other owners during setup.

Require a fresh character in newchar-items verification and select the newly created character. Cover setup errors, save serialization, deletion interleaving, SQL rollback, and ID reuse.

Co-Authored-By: Codex <[email protected]>
Use a Relaxed compare_exchange_weak retry loop to preserve monotonic unique 18-character names while remaining compatible with older stable Rust.

Co-Authored-By: Codex <[email protected]>
Track incoming static collider users separately from simulated collider lists. Maintain these links during add, removal, clear, and derived teardown; detach normal contacts and wake surviving users before deferred reclamation. Route living contact pruning through the same removal API.

Add public World API regressions for sleep/delete/cleanup/wake, two rigid users with one freed first, repeated static replacement, contact/mask alignment, and explicit contact removal.

Co-Authored-By: Codex <[email protected]>
Assert failed creation packets release cached inventory, name/account registrations, and IDs while keeping the lobby reusable for invalid-name rejection and same-name retry. Preserve chest durability, body-part placement, and supply stack coverage through the existing private creation helpers.

Remove the unsupported bag diagnostic from newchar-items verification while retaining its fresh bot and both SQL assertions.

Co-Authored-By: Codex <[email protected]>
Decode the native tooltip and buff-only flags independently and echo the tooltip flag when loading notes. Preserve legacy missing-song replies, buff-only behavior, and note ID widths; cover all flag combinations with actual packet and buff flow tests.

Co-Authored-By: OpenAI Codex <[email protected]>
@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 40004530008

Warning

No base build found for commit 180b4fd on rust-rewrite.
Coverage changes can't be calculated without a base build.
If a base build is processing, this comment will update automatically when it completes.

Coverage: 76.856%

Details

  • Patch coverage: 392 uncovered changes across 17 files (1548 of 1940 lines covered, 79.79%).

Uncovered Changes

Top 10 Files by Coverage Impact Changed Covered %
rust/crates/aaemu-game/src/systems/vehicles/slaves.rs 832 676 81.25%
rust/crates/aaemu-game/src/db_character.rs 104 13 12.5%
rust/crates/aaemu-game/src/systems/vehicles/data.rs 101 45 44.55%
rust/crates/aaemu-game/src/managers/character.rs 95 78 82.11%
rust/crates/aaemu-game/src/models/item.rs 26 13 50.0%
rust/crates/aaemu-testclient/src/verify.rs 56 44 78.57%
rust/crates/aaemu-game/src/managers/item.rs 92 83 90.22%
rust/crates/aaemu-game/src/systems/skills/ext.rs 8 0 0.0%
rust/crates/aaemu-game/src/systems/ai/collision/mod.rs 16 9 56.25%
rust/crates/aaemu-game/src/systems/skills/effects/special/misc.rs 27 20 74.07%
Total (28 files) 1940 1548 79.79%

Coverage Regressions

Requires a base build to compare against. How to fix this →


Coverage Stats

Coverage Status
Relevant Lines: 260793
Covered Lines: 200435
Line Coverage: 76.86%
Coverage Strength: 29207.47 hits per line

💛 - Coveralls

@NickMesser
NickMesser merged commit 79d3d0c into rust-rewrite Oct 23, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants