Repository navigation
fix: harden Rust gameplay, persistence and protocol flows - #43
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <[email protected]>
DoodadFuncOreMine / RockMine / Shear were log-only stubs, so the phase never advanced and the authored loot / depletion / regrow groups never ran. They now set ToNextPhase like DoodadFuncCutdown; labor stays the gathering skill's consume_lp and the 1.2 server (C# and Rust) does not validate mainhand_tool_id. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Exercise live and stale character selection against a closed pool, and verify forced cleanup retains departing financial state without disturbing other sessions. Co-Authored-By: GPT-6.1 Sol <[email protected]>
…tion set CSStartInteraction answered 0 for an NPC without a function flag, so the client never offered what npc_interactions gives it (the beauty salon helper's 'Enter the beauty salon', skill 22780). npc_interactions is loaded per npc_interaction_set_id; when no function applies the answer lists the set's skills in table order, and the function still wins when there is one. Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
Commit each selected building effect only after a checked full material debit, then flush item callbacks after releasing the housing lock. Preserve optional consumption for other effects. Report actual container consumption exactly once, including depleted preferred stacks, while preserving item tasks and callback order. Add deterministic race, payment, callback and compatibility regressions. Validation: 204 focused library tests passed; 15 housing tests ignored. Game all-target clippy with -D warnings and cargo fmt --all -- --check passed. Co-Authored-By: Codex <[email protected]>
…sted, tower def list, play sound) - SCCriminalArrested: the criminal's obj id is a 3-byte bc (x2game 397b6870), not a u32. - SCTowerDefList: the count is a u8 and the client reads at most 100 entries (397caad0). - SCPlaySound: the NPC of a kind-2 (bubble) cue is a bc (397bea30), not a u32. Each extra byte shifted the following fields, so the client read garbage names / ids. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Authorize gathering before cast mutations and phase execution. Preserve explicit Use/FakeUse bindings and automatic loot, and define the scoped legacy server compatibility mapping with normal labor and quest requirements. Prevent an owned mate from advancing a paid gathering phase for a free character loot retry. Add packet-flow regressions and compact coverage. Ore uses its real item definition; removed rock/sheep loot definitions are explicit test-only stand-ins. Native UI dispatch remains unverified. Co-Authored-By: GPT-6.1 Sol <[email protected]>
# Conflicts: # rust/crates/aaemu-game/PORTING.md
# Conflicts: # rust/crates/aaemu-game/PORTING.md
Treat missing hair as template 0 when checking whether a salon hairstyle needs replacement. Keep receipts authoritative and preserve existing certificate settlement and failure behavior. Co-Authored-By: Codex <[email protected]>
Decode the native tooltip and buff-only flags independently and echo the tooltip flag when loading notes. Preserve legacy missing-song replies, buff-only behavior, and note ID widths; cover all flag combinations with actual packet and buff flow tests. Co-Authored-By: OpenAI Codex <[email protected]>
Coverage Report for CI Build 40009891755Warning No base build found for commit Coverage: 77.012%Details
Uncovered Changes
Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
# Conflicts: # rust/crates/aaemu-game/PORTING.md
NickMesser
marked this pull request as ready for review
October 23, 2026 19:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Character creation could expose or leak starter inventory after persistence failed; gathering and cannon requests could bypass authority; construction could advance without full material payment; and recycled static physics colliders could panic a sleeping ship. This integration fixes those paths and adds regression coverage, alongside the reviewed gameplay/data and 1.2 packet corrections in #34–#42 and #44. All original PR heads remain in the history.
Changes include authenticated internal reconnect ownership, bounded registration decoding, overflow-safe packet reads and frame boundaries, deterministic session recovery tests, Python ratchet tests in the local CI gate, transactional character/inventory cleanup and forced-fresh verification, atomic construction payment and exact consumption callbacks, gathering skill/caster authorization, instance Return visibility, persistent ship equipment and gunner lifecycle fixes, static collider lifetime bookkeeping, Unix writer-lock release, NPC interaction lists, three client packet layouts, empty-slot salon hair creation, and uncached music-note replies.
Validation on
79d3d0c1c1a115505ce0d3d33e1a09833ad2d40a:-D warnings, and packet coverage ratchet passed.live entitypanic and then passed with the lifetime fix.d0991c0; the subsequent source delta is limited to music code/tests and its porting note.79d3d0c: 7/7 cases passed with exact note bodies and tooltip flags, missing-note replies, preserved u64 aliasing, requester-only buff targets, and an unchanged seeded MySQL row. The first three replies were delayed/coalesced; offline validation matched their ordered bytes. No new server ERROR/panic occurred; 10 static-data/timing warnings were recorded. All eight production EXE/PDB hashes matched, and all lane-owned processes/listeners were stopped.Limits: native UI/menu selection, implicit gathering UI dispatch, audio playback and composition, projectile impact, and distant Return presentation were not verified in a real client. Return visibility and the construction interleaving are covered by deterministic packet/flow tests. Gathering skill mappings are documented server compatibility policy; missing rock/sheep item templates are test fixtures only. Tree quest setup used GM progression. Expected restart/setup errors and timing/static-data warnings were audited separately; no unexplained runtime panics remained.
Three CodeQL literal-credential findings were scoped to pure
#[cfg(test)]configuration fixtures and dismissed as used in tests with source evidence; no scan or query was disabled.