Repository navigation
Conversation
…ype-check
PointerTile::broadcast keeps the rank, so broadcasting a scalar pointer tile
(rank 0) straight to { [128] } does not compile. Reshape to rank 1 first with
reshape_ptr, then broadcast_ptr, then offset_tile, as separate annotated lets.
Fixes NVIDIA#1597
Signed-off-by: Imanol Gomez <[email protected]>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
PointerTileexamples incutile-book/reference/dsl-api.mdbroadcast a scalar (rank-0) pointer tile straight to{ [128] }.PointerTile::broadcastkeeps the rank, so rustc rejects them (E0308: expectedShape_0, foundShape_1<'_, 128>). This reshapes to rank 1 first withreshape_ptr, thenbroadcast_ptr, thenoffset_tile, as separate annotatedlets. Fixes #1597.Changes
cutile-book/reference/dsl-api.md: thePointerTiletype section and the pointer-load example under "Pointer-based loads and stores". Documentation only; no code changes.Testing
Documentation-only change. The corrected form (same steps, same types) compiles with the compile-only API (
KernelCompiler, target sm_89, no GPU needed): kerneldocs_fixedin https://github.com/ImanolGo/murmuration-kernels/tree/0b219ab8b3fcdb8392f653a1180ace3d433f3952/upstream-repros/cutile-dsl-friction . The original snippet fails rustc in the same crate withcargo build --features docs-snippet.Not run:
just -f cuda-oxide/Justfile checkandcutile-rs/scripts/run_all.sh. The author has no sm_80+ GPU on this machine, and the change touches only Markdown.just -f cuda-oxide/Justfile checkpasses (not applicable to a Markdown-only change; not run)cargo oxide run <example>passes (not applicable)Checklist
git commit -s)AI contribution: drafted and checked with Claude Code (Anthropic); submitted by me.