Skip to content

Accept cold-path hints in checked collective kernels - #1593

Draft
tpn wants to merge 104 commits into
NVIDIA:mainfrom
tpn:codex/coop-interop-cold-path
Draft

tpn wants to merge 104 commits into
NVIDIA:mainfrom
tpn:codex/coop-interop-cold-path

Conversation

@tpn

@tpn tpn commented Oct 21, 2026 •

Copy link
Copy Markdown

Checked collective kernels can reach Rust's cold_path hint through ordinary index arithmetic. Recognize the genuine nullary, non-generic unit hint in the MIR importer so the existing rustc-free checker can continue participation, memory and scratch analysis. The owning native example keeps this path covered.

Review this change (two files, ten added lines). Depends on #1592. GitHub's Files changed tab includes prerequisites because the base is still main; a maintainer must create upstream parent branches or land prerequisites before these existing PRs can have narrow stacked bases.

Validation: 1,274 affected host tests, strict checks and the four original hint controls pass. The ordinary Git compiler builds the native example and passes its 2,304 GPU values. A fresh HTTPS installation builds the same source; all three executable sections, four ABI sections, resource/launch facts and non-debug relocations match that ordinary build. Whole binary/CUBIN/LLVM bytes differ. GPU evidence belongs to the ordinary build; current-head CI remains separate.

fxeqxmulfx and others added 30 commits October 12, 2026 02:14
With `lto = "fat"` or `lto = "thin"`, the build of a binary that uses a
library with kernels stopped with an error: "failed to get bitcode from
object file for LTO (Can't find section .llvmbc)". rustc keeps a list of
the Rust objects in each rlib. This list contains the objects of all
modules. With LTO, rustc reads bitcode from these objects and removes
them from the link. The artifact objects have no bitcode.

If a session writes an rlib, the backend now gives each artifact object
to rustc as the DWARF object of its module. This object is in the rlib,
but it is not in the list. LTO does not read this object, and the linker
gets it from the rlib.

The system linker does not get the DWARF objects. If the session also
writes a binary or a dynamic library, the backend gives the artifact
objects to this linker as link arguments. With
`-Zlink-native-libraries=no`, rustc does not give link arguments to the
linker. Then the artifact objects of this session are Rust objects, as
before.

The book said that `join_codegen()` and `link()` only call the LLVM
backend. Now it tells what they add to the outputs.

CI builds `cuda_module_in_lib` with fat LTO. The library is an rlib, and
then an rlib and a cdylib. After each build, CI makes sure that the
binary has the PTX bundles of the library and of the binary. It also
makes sure that the cdylib has the PTX bundle of the library.

Fixes NVIDIA#1495

Signed-off-by: Mikhail Borisov <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Use Cargo target names for standalone emit-ltoir artifacts. Bind the
compiler and reader to the same intermediate directory when invoked
from a Cargo workspace member.

Signed-off-by: Trent Nelson <[email protected]>
Accept ordered external LTO files when materializing embedded cubins.
Include their content in the codegen fingerprint and verify owned bytes
before linking through the existing finalizer. Preserve inputs that
overlap generated output paths and diagnose unresolved device symbols.

Add a standalone CUDA FFI example and a native regression script.

Signed-off-by: Trent Nelson <[email protected]>
Reuse existing example dependency pins and classify external LTO as
an FFI fixture. Run its linking regression in native sweeps and verify
relocatable debug output in the existing full-debug route.

Signed-off-by: Trent Nelson <[email protected]>
Preserve exact geometry and fixed dynamic shared-memory requirements
through artifact loading so preparation can select and validate the
compiled allocation. Keep artifact writers and readers on one in-tree
implementation while preserving legacy bundles without launch facts.

Signed-off-by: Trent Nelson <[email protected]>
Combine the reviewed compiler prerequisites for native library calls.
Keep the external LTO fixture on the shared in-tree artifact implementation.

Signed-off-by: Trent Nelson <[email protected]>
Use the reviewed Cargo target and output-directory correction in the
combined compiler prerequisite tree.

Signed-off-by: Trent Nelson <[email protected]>
Resolve concrete registration functions and scalar argument types during
device compilation, then invoke the native provider and link its owned
LTO output through the ordinary artifact finalizer.

Signed-off-by: Trent Nelson <[email protected]>
Carry the convergence marker through private dependency metadata and
emit it on each marked LLVM declaration before native optimization.
Deduplicate repeated extern symbols while rejecting incompatible
signatures and convergence requirements.

Signed-off-by: Trent Nelson <[email protected]>
Signed-off-by: Trent Nelson <[email protected]>

# Conflicts:
#	cuda-oxide/crates/rustc-codegen-cuda/src/library.rs
Keep original MIR and static identities while emitting checked helper

bodies for each root. Route typed calls and native plans through those

bodies so shared helpers can use distinct block shapes.

Signed-off-by: Trent Nelson <[email protected]>
Treat each block as one cluster when a known earlier target is selected.
Bind a device hint only after this fallback is used, so later feature
selection cannot silently change its semantics. Keep raw intrinsic and
cluster operation target requirements intact.

Signed-off-by: Trent Nelson <[email protected]>
tpn added 12 commits October 23, 2026 01:00
Recognize genuine core integer methods at the import boundary and
retain their scalar effects on the original direct calls. Other
helper calls keep their conservative borrow handling.

Signed-off-by: Trent Nelson <[email protected]>
Check signed and unsigned imports and preserve ordinary call effects
when no direct target is selected. Clarify the source metadata comment.

Signed-off-by: Trent Nelson <[email protected]>
Supply the warp width in the existing importer retention fixture.

Signed-off-by: Trent Nelson <[email protected]>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants